Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in dimensionality in heat flux evaluation within slab model is rectified. #2075

Closed
wants to merge 1 commit into from

Conversation

joshi994
Copy link
Contributor

TYPE: Bug fix

KEYWORDS: Slab model, sensible heat flux, heat capacity. skin temperature, thermal balance

SOURCE: Parag Joshi (Brookhaven National Laboratory)

DESCRIPTION OF CHANGES:
Problem: The sensible heat flux evaluation in the slab model is incorrect. The flux is missing the factor of thermal capacity.

Solution: The error is fixed following the formulation and verified by evaluating the dimensions post corrections.

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. No test is performed for quantifying the impact of the error.

RELEASE NOTE: The sensible heat flux evaluation turned out to be dimensionally inconsistent which led to the incorrect evaluation of the ground temperature. Following the formulation (Link: https://journals.ametsoc.org/view/journals/apme/21/11/1520-0450_1982_021_1594_ahrmot_2_0_co_2.xml), refer to the equations 5a and 11 of the article in the link, the error is highlighted.

@joshi994 joshi994 requested a review from a team as a code owner June 29, 2024 21:23
@dudhia
Copy link
Collaborator

dudhia commented Jul 1, 2024

The units of FLHC are W/m2/K, so this code is already correct.

@joshi994 joshi994 closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants