Inconsistency in dimensionality in heat flux evaluation within slab model is rectified. #2075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: Bug fix
KEYWORDS: Slab model, sensible heat flux, heat capacity. skin temperature, thermal balance
SOURCE: Parag Joshi (Brookhaven National Laboratory)
DESCRIPTION OF CHANGES:
Problem: The sensible heat flux evaluation in the slab model is incorrect. The flux is missing the factor of thermal capacity.
Solution: The error is fixed following the formulation and verified by evaluating the dimensions post corrections.
ISSUE: For use when this PR closes an issue.
Fixes #123
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status master
to get formatted list)TESTS CONDUCTED:
RELEASE NOTE: The sensible heat flux evaluation turned out to be dimensionally inconsistent which led to the incorrect evaluation of the ground temperature. Following the formulation (Link: https://journals.ametsoc.org/view/journals/apme/21/11/1520-0450_1982_021_1594_ahrmot_2_0_co_2.xml), refer to the equations 5a and 11 of the article in the link, the error is highlighted.