Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.5.1 #2052

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Release v4.5.1 #2052

wants to merge 3 commits into from

Conversation

tliartsi
Copy link

The first line should be a single-line "purpose" for this change

TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]

KEYWORDS: 5 to 10 words related to commit, separated by commas

SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member

DESCRIPTION OF CHANGES:
Problem:
Generally or specifically, what was wrong and needed to be addressed?

Solution:
What was down algorithmically and in the source code to address the problem?

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)

TESTS CONDUCTED:

  1. Do mods fix problem? How can that be demonstrated, and was that test conducted?
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

@tliartsi tliartsi requested review from a team as code owners May 22, 2024 10:08
@weiwangncar
Copy link
Collaborator

@tliartsi Please make PR using the latest release of the model - right now that version is 4.6.0. We do not make changes to previously released code. Also please edit the PR message (top box) to describe what you would like to change and reason for the change.

@dudhia
Copy link
Collaborator

dudhia commented May 22, 2024

The scale of this change implies it is a new scheme and should target the develop branch.

@weiwangncar weiwangncar changed the base branch from release-v4.5.1 to release-v4.6.0 May 22, 2024 16:08
@weiwangncar weiwangncar changed the base branch from release-v4.6.0 to develop May 22, 2024 16:09
@weiwangncar
Copy link
Collaborator

@tliartsi It looks like your PR can be updated with respect to our develop branch (which is the same as 4.6.0 branch at this time). Please edit the PR message as suggested before.

@dudhia
Copy link
Collaborator

dudhia commented May 29, 2024

@tliartsi Note that we are still waiting for a description of this method. Is it a new option or addition to an existing option. Also note that there are conflicts with the existing up-to-date code. We need all this resolved before we can start considering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants