Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove print from microphysics driver #2040

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Remove print from microphysics driver #2040

merged 1 commit into from
Apr 29, 2024

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Apr 26, 2024 •
edited
Loading

TYPE: almost text only

KEYWORDS: extra print, microphysics driver

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
PR-1876 accidentally turned on a diagnostic print for max and min vertical motions

Solution:
The print is removed as in previous code.

LIST OF MODIFIED FILES:
M phys/module_microphysics_driver.F

TESTS CONDUCTED:
The Jenkins tests are all passing.

RELEASE NOTE:

@weiwangncar weiwangncar requested a review from a team as a code owner April 26, 2024 17:08
@weiwangncar
Copy link
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator Author

@dudhia @smileMchen Can you review the PR? Thanks!

@smileMchen smileMchen self-requested a review April 29, 2024 15:56
@weiwangncar weiwangncar merged commit a977865 into wrf-model:release-v4.6.0 Apr 29, 2024
1 of 5 checks passed
@weiwangncar weiwangncar deleted the rm-print branch April 29, 2024 16:07
islas pushed a commit to islas/WRF that referenced this pull request Jun 10, 2024
@weiwangncar @islas
Remove print max/min w in microphysics driver (wrf-model#2040)
59eda8a 
TYPE: almost text only

KEYWORDS: extra print, microphysics driver

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
PR-1876 accidentally turned on a diagnostic print for max and min vertical motions.

Solution:
The print is removed as in previous code.

LIST OF MODIFIED FILES: 
M       phys/module_microphysics_driver.F

TESTS CONDUCTED: 
The Jenkins tests are all passing.
islas pushed a commit to islas/WRF that referenced this pull request Jun 10, 2024
@weiwangncar @islas
Remove print max/min w in microphysics driver (wrf-model#2040)
16850bf 
TYPE: almost text only

KEYWORDS: extra print, microphysics driver

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
PR-1876 accidentally turned on a diagnostic print for max and min vertical motions.

Solution:
The print is removed as in previous code.

LIST OF MODIFIED FILES: 
M       phys/module_microphysics_driver.F

TESTS CONDUCTED: 
The Jenkins tests are all passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smileMchen smileMchen smileMchen approved these changes

@dudhia dudhia dudhia approved these changes

Assignees
No one assigned
Labels
release-v4.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiwangncar @smileMchen @dudhia