Final bug fixes and tuning of MYNN PBL for v4.6 #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regression test results: |
|
@dudhia @joeolson42 Can you review and approve this PR? |
joeolson42
approved these changes
Apr 15, 2024
dudhia
approved these changes
Apr 16, 2024
weiwangncar
changed the title
|
@smileMchen Can you help approve this PR? Somehow Joe's approval wasn't counted.... |
smileMchen
approved these changes
Apr 16, 2024
islas
pushed a commit
to islas/WRF
that referenced
this pull request
Jun 10, 2024
TYPE: bug fix + tuning KEYWORDS: MYNN EDMF SOURCE: Joseph Olson (NOAA-GSL) DESCRIPTION OF CHANGES: Problems: 1. overly diminished TKE in stable PBL - always dropping to the lower limit 2. negative mass flux area fractions found (rarely) with activation criteria change from flt to fltv. 3. edmf diagnostics erroneously included rho. Solution: 1. retuning of mixing lengths and stability function for momentum - mostly just limit changes. 2. check for mf transfer of heat out of the lowest layer was modified 3. removed rho. LIST OF MODIFIED FILES: phys/module_bl_mynn.F TESTS CONDUCTED: 1. Tested in RRFSv1. 2. The Jenkins tests are all passing. This commit contains the final tuning of the MYNN for RRFSv1, and part of the update for 4.6 (together with PR-1938 and 1996).
islas
pushed a commit
to islas/WRF
that referenced
this pull request
Jun 10, 2024
TYPE: bug fix + tuning KEYWORDS: MYNN EDMF SOURCE: Joseph Olson (NOAA-GSL) DESCRIPTION OF CHANGES: Problems: 1. overly diminished TKE in stable PBL - always dropping to the lower limit 2. negative mass flux area fractions found (rarely) with activation criteria change from flt to fltv. 3. edmf diagnostics erroneously included rho. Solution: 1. retuning of mixing lengths and stability function for momentum - mostly just limit changes. 2. check for mf transfer of heat out of the lowest layer was modified 3. removed rho. LIST OF MODIFIED FILES: phys/module_bl_mynn.F TESTS CONDUCTED: 1. Tested in RRFSv1. 2. The Jenkins tests are all passing. This commit contains the final tuning of the MYNN for RRFSv1, and part of the update for 4.6 (together with PR-1938 and 1996).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix + tuning
KEYWORDS: MYNN EDMF
SOURCE: Joseph Olson (NOAA-GSL)
DESCRIPTION OF CHANGES:
Problems:
Solution:
LIST OF MODIFIED FILES:
phys/module_bl_mynn.F
TESTS CONDUCTED:
This commit contains the final tuning of the MYNN for RRFSv1, and part of the update for 4.6 (together with PR-1938 and 1996).