Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded depends #2029

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Remove unneeded depends #2029

merged 1 commit into from
Mar 26, 2024

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Mar 25, 2024 •
edited
Loading

TYPE: bug fix, clean up

KEYWORDS: dependencies, unused

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Some dependency is declared twice, some are no longer needed.

Solution:
Remove un-used dependencies. Complementary to PR-1950.

LIST OF MODIFIED FILES:
M main/depend.common

TESTS CONDUCTED:

  1. Tested on Derecho with 6 proc to compile
  2. The Jenkins tests are all passing.

RELEASE NOTE:

@weiwangncar weiwangncar requested a review from a team as a code owner March 25, 2024 20:42
islas
islas approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@islas islas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard previous comment, I saw after that the removed dep was a duplicate

@weiwangncar
Copy link
Collaborator Author

The regression test results:

Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia
dudhia reviewed Mar 26, 2024
View reviewed changes
main/depend.common
module_sf_bep.o: \
module_sf_urban.o


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this one is removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dudhia This dependency is declared elsewhere in this file, hence redundant.

@weiwangncar weiwangncar merged commit 9c09ef9 into wrf-model:release-v4.6.0 Mar 26, 2024
1 of 4 checks passed
islas pushed a commit to islas/WRF that referenced this pull request Jun 10, 2024
@weiwangncar @islas
remove unneeded depends (wrf-model#2029)
aee55d7 
TYPE: bug fix, clean up

KEYWORDS: dependencies, unused

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Some dependency is declared twice, some are no longer needed.

Solution:
Remove un-used dependencies. Complimentary to PR-1950.

LIST OF MODIFIED FILES: 
M      main/depend.common

TESTS CONDUCTED: 
1. Tested on Derecho with 6 proc to compile
2. The Jenkins tests are all passing.
islas pushed a commit to islas/WRF that referenced this pull request Jun 10, 2024
@weiwangncar @islas
remove unneeded depends (wrf-model#2029)
d9baa16 
TYPE: bug fix, clean up

KEYWORDS: dependencies, unused

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Some dependency is declared twice, some are no longer needed.

Solution:
Remove un-used dependencies. Complimentary to PR-1950.

LIST OF MODIFIED FILES: 
M      main/depend.common

TESTS CONDUCTED: 
1. Tested on Derecho with 6 proc to compile
2. The Jenkins tests are all passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudhia dudhia dudhia approved these changes

@islas islas islas approved these changes

Assignees
No one assigned
Labels
release-v4.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weiwangncar @dudhia @islas