Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build of diffwrf binaries #2013

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

islas
Copy link
Collaborator

@islas islas commented Feb 23, 2024

TYPE: enhancement

KEYWORDS: cmake, diffwrf

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
New CMake build did not create binaries for io_* diffwrf

Solution:
Slight restructure of certain targets to allow for easy creation of the diffwrf executables. Since previously all diffwrf binaries were named the same, to house them int the same install/bin/ location they have been prefix with the type of io or shorthand of that option ( io_int -> diffwrf_int, io_netcdf -> diffwrf_nc, io_netcdfpar -> diffwrf_ncpar ).

LIST OF MODIFIED FILES:
M CMakeLists.txt
M external/io_int/CMakeLists.txt
M external/io_netcdf/CMakeLists.txt
M external/io_netcdfpar/CMakeLists.txt

TESTS CONDUCTED:

  1. Diffwrf execs should now be located in cmake install location

RELEASE NOTE:
CMake build of diffwrf binaries

@islas islas requested review from a team as code owners February 23, 2024 20:29
@weiwangncar
Copy link
Collaborator

@islas I haven't received reg test report from this PR either.

@weiwangncar
Copy link
Collaborator

@islas I haven't received reg test report from this PR either.

@islas It's possible that since this PR only changes .txt files, and no tests are triggered.
@mgduda Can you review this PR, please?

@islas islas merged commit e2da0f6 into wrf-model:develop Feb 28, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants