Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile on Cygwin #2003

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix compile on Cygwin #2003

merged 2 commits into from
Feb 5, 2024

Conversation

weiwangncar
Copy link
Collaborator

Allow compilation on Cygwin to complete

TYPE: bug fix

KEYWORDS: compilation, Cygwin,

SOURCE: Daniel Wesloh (Penn State)

DESCRIPTION OF CHANGES:
Problem:
Compiling WRF failed on Cygwin due to lack of netCDF4

Solution:
Match assumptions about USENETCDFPAR (#1743 would also fix this) and pass flags to allow legacy Fortran constructs (disallowed by default with GCC 10)

ISSUE: For use when this PR closes an issue.
Fixes #1271

LIST OF MODIFIED FILES:

M       configure
M       doc/README.cygwin.md
M       doc/README.netcdf4par

TESTS CONDUCTED:

  1. Checked whether model compiles on Cygwin in Fix cygwin compile DWesl/WRF#1
  2. The Jenkins tests have passed.

RELEASE NOTE: Fix compilation on Cygwin.

@islas islas changed the base branch from master to develop February 2, 2024 21:10
islas
islas previously approved these changes Feb 2, 2024
@weiwangncar
Copy link
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator Author

@islas Need to re-approve... Thanks...

@weiwangncar weiwangncar merged commit 53f3460 into wrf-model:develop Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build on cygwin
3 participants