Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency module_wind_mav to module_physics_init #1999

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

islas
Copy link
Collaborator

@islas islas commented Jan 30, 2024

TYPE: bug

KEYWORDS: make, dependency

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
PR #1944 adds module_wind_mav to module_physics_init, but does not update the main/depend.common file to add the dependency during compilation

Solution:
Add module_wind_mav.o as a dependency to module_physics_init.o in the main/depend.common file

ISSUE:
Fixes comment noted in #1944

LIST OF MODIFIED FILES:
M main/depend.common

TESTS CONDUCTED:

  1. Local compilation in single job mode -j 1 should work now

RELEASE NOTE:
Add missing dependency module_wind_mav to module_physics_init

@islas islas requested a review from a team as a code owner January 30, 2024 21:31
@islas
Copy link
Collaborator Author

islas commented Jan 30, 2024

@weiwangncar This should fix the issue noted in #1944

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator

@islas While you're doing this, can you add the following too:
module_sf_bep.o: it showed up twice in the file, the second one should go
module_sf_mynn.o: it only uses module_model_constants.o

@islas
Copy link
Collaborator Author

islas commented Jan 31, 2024

@weiwangncar Since this PR is specifically fixing a discrete issue arising from another PR I think it would be best to limit the changes to an isolated fix for that issue.

@weiwangncar
Copy link
Collaborator

@islas OK, I will make another PR for those.

@weiwangncar weiwangncar merged commit 9b08bf2 into wrf-model:develop Jan 31, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants