Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared physics nTiedtke #1994

Merged
merged 9 commits into from
Feb 2, 2024

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Jan 26, 2024

TYPE: enhancement, new feature

KEYWORDS: shared physics, new Tiedtke

SOURCE: internal

DESCRIPTION OF CHANGES:
Add new Tiedtke scheme from the shared physics directory, which is ccpp-compliant.

Solution:
The CCPP-compliant new Tiedtke code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo.

LIST OF MODIFIED FILES:
M arch/postamble
M arch/preamble
M clean
M main/depend.common
M phys/Makefile
M phys/module_cu_ntiedtke.F
M phys/module_cumulus_driver.F
A phys/physics_mmm/cu_ntiedtke.F90

TESTS CONDUCTED:

  1. The runs before and after this change produce bit-for-bit results when compiled with -d option.
  2. The Jenkins tests are all passing.

RELEASE NOTE: Add new Tiedtke cumulus scheme from the future shared MMM-physics repository.

	new file:   phys/physics_mmm/LICENSE
	new file:   phys/physics_mmm/README.md
	new file:   phys/physics_mmm/cu_ntiedtke.F90
	new file:   phys/physics_mmm/cu_ntiedtke.meta
- phys/Makefile: add physics_mmm/cu_ntiedtke.F to the modules to be compiled
- main/depend.common: dependencies for module_cu_ntiedtke.F and new cu_ntiedtke.F
- arch/postamble: add .F90.o and .F90.f90 rules
- clean: add phys/physics_mmm/ to be cleaned
@weiwangncar
Copy link
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia
dudhia previously approved these changes Feb 1, 2024
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that the arg list now has the constants

smileMchen
smileMchen previously approved these changes Feb 1, 2024
@weiwangncar weiwangncar dismissed stale reviews from smileMchen and dudhia via f9535ed February 2, 2024 01:01
@weiwangncar
Copy link
Collaborator Author

@dudhia I have to merge these PRs one at a time...

@weiwangncar weiwangncar merged commit c6cc0c5 into wrf-model:develop Feb 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants