Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared physics wsm6 #1993

Merged
merged 15 commits into from
Feb 2, 2024
Merged

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Jan 25, 2024

TYPE: enhancement, new feature

KEYWORDS: shared physics, WSM6

SOURCE: internal

DESCRIPTION OF CHANGES:
Add WSM6 microphysics scheme from the shared physics directory, which is ccpp-compliant.

Solution:
The CCPP-compliant WSM6 MP code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo.

LIST OF MODIFIED FILES:
M arch/postamble
M arch/preamble
M clean
M main/depend.common
M phys/Makefile
M phys/module_microphysics_driver.F
M phys/module_mp_wsm6.F
M phys/module_physics_init.F
A phys/physics_mmm/module_libmassv.F90
A phys/physics_mmm/mp_radar.F90
A phys/physics_mmm/mp_wsm6.F90
A phys/physics_mmm/mp_wsm6_effectRad.F90
M share/module_model_constants.F

TESTS CONDUCTED:

  1. The runs before and after this change produce bit-for-bit results when compiled with -d option.
  2. Are the Jenkins tests all passing?

RELEASE NOTE: Add WSM6 microphysics scheme from the future shared MMM-physics repository.

	new file:   physics_mmm/LICENSE
	new file:   physics_mmm/README.md
	new file:   physics_mmm/mp_radar.F90
	new file:   physics_mmm/mp_wsm6.F90
	new file:   physics_mmm/mp_wsm6.meta
	new file:   physics_mmm/mp_wsm6_effectRad.F90
	new file:   physics_mmm/mp_wsm6_effectRad.meta
- modify wsm6 init call which is now resides in physics_mmm/mp_wsm6.F
…ectory

- main/depend.common: change and add dependencies for the files in phys/physics_mmm/
@weiwangncar
Copy link
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia
dudhia previously approved these changes Feb 1, 2024
physics_init module should now depend on mp_wsm6 in physics_mmm/ directory.
@dudhia
Copy link
Collaborator

dudhia commented Feb 2, 2024 via email

@weiwangncar
Copy link
Collaborator Author

weiwangncar commented Feb 2, 2024

@dudhia I believe so: I see code

 real(kind=kind_phys),intent(in):: re_qc_bg,re_qi_bg,re_qs_bg

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more changes than expected to effectRad

@weiwangncar weiwangncar merged commit 81410a3 into wrf-model:develop Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants