-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared physics wsm6 #1993
Merged
weiwangncar
merged 15 commits into
wrf-model:develop
from
weiwangncar:shared-physics-wsm6
Feb 2, 2024
Merged
Shared physics wsm6 #1993
weiwangncar
merged 15 commits into
wrf-model:develop
from
weiwangncar:shared-physics-wsm6
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: physics_mmm/LICENSE new file: physics_mmm/README.md new file: physics_mmm/mp_radar.F90 new file: physics_mmm/mp_wsm6.F90 new file: physics_mmm/mp_wsm6.meta new file: physics_mmm/mp_wsm6_effectRad.F90 new file: physics_mmm/mp_wsm6_effectRad.meta
- modify wsm6 init call which is now resides in physics_mmm/mp_wsm6.F
…ectory - main/depend.common: change and add dependencies for the files in phys/physics_mmm/
The regression test results:
|
LICENSE, README.md, mp_wsm6.meta, mp_wsm6_effectRad.meta
dudhia
reviewed
Feb 1, 2024
islas
reviewed
Feb 1, 2024
dudhia
previously approved these changes
Feb 1, 2024
physics_init module should now depend on mp_wsm6 in physics_mmm/ directory.
smileMchen
approved these changes
Feb 1, 2024
Is it true that the effectRad has been reorganized to include the *_bg
arrays as part of this?
…On Thu, Feb 1, 2024 at 4:21 PM smileMchen ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#1993 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77CUDSEHM6264YDWRM3YRQPO7AVCNFSM6AAAAABCJWC4W6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJXHA4DQOJRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@dudhia I believe so: I see code
|
dudhia
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more changes than expected to effectRad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement, new feature
KEYWORDS: shared physics, WSM6
SOURCE: internal
DESCRIPTION OF CHANGES:
Add WSM6 microphysics scheme from the shared physics directory, which is ccpp-compliant.
Solution:
The CCPP-compliant WSM6 MP code will be residing in phys/physics_mmm/ directory. Currently it is a copy of the code from the future MMM-physics repo.
LIST OF MODIFIED FILES:
M arch/postamble
M arch/preamble
M clean
M main/depend.common
M phys/Makefile
M phys/module_microphysics_driver.F
M phys/module_mp_wsm6.F
M phys/module_physics_init.F
A phys/physics_mmm/module_libmassv.F90
A phys/physics_mmm/mp_radar.F90
A phys/physics_mmm/mp_wsm6.F90
A phys/physics_mmm/mp_wsm6_effectRad.F90
M share/module_model_constants.F
TESTS CONDUCTED:
RELEASE NOTE: Add WSM6 microphysics scheme from the future shared MMM-physics repository.