Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T APPROVE! added model stop for ghg_input with nonsupported radiation options #1936

Open
wants to merge 4 commits into
base: release-v4.5.2
Choose a base branch
from

Conversation

kkeene44
Copy link
Collaborator

@kkeene44 kkeene44 commented Nov 9, 2023

TYPE: bug fix

KEYWORDS: ghg_input, radiation, module_check_a_mundo

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
If a user had ghg_input turned on, but wasn't using one of the supported radiation physics options (i.e., not CAM, RRTM, RRTMG, or RRTMG_fast), the model would give an "ERROR" message, but wouldn't stop, nor would it make any changes to the settings. As long as everything else was correct, it would continue and write out the SUCCESS message at the end of the log files.

Solution:
Added a "count_fatal_error = count_fatal_error + 1" to the check for this in module_check_a_mundo.F.

LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. Now, if non-supported radiation options are used with ghg_input, the model stops with the following message:
    -- ERROR: ghg_input available only for these radiation schemes: CAM, RRTM, RRTMG, RRTMG_fast
    And the LW and SW schemes must be reasonably paired together:
    OK = CAM LW with CAM SW
    OK = RRTM, RRTMG LW or SW, RRTMG_fast LW or SW may be mixed
    -------------- FATAL CALLED ---------------
    FATAL CALLED FROM FILE: LINE: 2794
    NOTE: 1 namelist settings are wrong. Please check and reset these options

  2. Are the Jenkins tests all passing? Waiting for results.

RELEASE NOTE: A bug fix was added to ensure the model stops when using ghg_input and a non-supported radiation physics option (i.e., anything other than CAM, RRTM, RRTMG, or RRTMG_fast).

dudhia
dudhia previously approved these changes Dec 12, 2023
@dudhia
Copy link
Collaborator

dudhia commented Dec 12, 2023

Is this one not passing due to some regtest namelists not being consistent with the GHG switch?

Deleted a blank line to force a reg-test
@dudhia
Copy link
Collaborator

dudhia commented Dec 13, 2023

Can someone look at failed checks?

@kkeene44
Copy link
Collaborator Author

kkeene44 commented Dec 13, 2023

@dudhia
I'm working on it. The tests that are failing are due to reg-test namelists that use NO radiation. ghg_input = 0 was added to all other necessary namelists, but not those set to 0. I'm adding that now, then will do another test with the updated reg-test.

Added a blank line to trigger reg-test
smileMchen
smileMchen previously approved these changes Dec 14, 2023
Commenting out change to see if reg-test will pass
@kkeene44
Copy link
Collaborator Author

This reg-test only passed because the change was commented out. Don't approve it!

@kkeene44 kkeene44 changed the title added model stop for ghg_input with nonsupported radiation options DON'T APPROVE! added model stop for ghg_input with nonsupported radiation options Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants