change wrf_error_fatal and wrf_message calls to macros to remain unif… #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regression test results: |
dudhia
approved these changes
Jul 7, 2023
smileMchen
approved these changes
Jul 7, 2023
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…ied with MPAS (wrf-model#1891) TYPE: text only KEYWORDS: urban schemes, message calls SOURCE: internal DESCRIPTION OF CHANGES: Problem: The three urban scheme routines have a few wrf_message and wrf_error_fatal calls that should be replaced by macros defined at the top of modules so that the code maintains consistency with those in MPAS. Solution: The calls are replaced by the macros. LIST OF MODIFIED FILES: M phys/module_sf_bem.F M phys/module_sf_bep_bem.F M phys/module_sf_urban.F TESTS CONDUCTED: 1. The code compiles. No impact on results. 2. The Jenkins tests are all passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: urban schemes, message calls
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The three urban scheme routines have a few wrf_message and wrf_error_fatal calls that should be replaced by macros defined at the top of modules so that the code maintains consistency with those in MPAS.
Solution:
The calls are replaced by the macros.
LIST OF MODIFIED FILES:
M phys/module_sf_bem.F
M phys/module_sf_bep_bem.F
M phys/module_sf_urban.F
TESTS CONDUCTED: