Add scale-aware to the new Tiedtke cu scheme as an option #1806

weiwangncar · 2023-01-11T08:45:42Z

Add scale-aware to the new Tiedtke scheme as an option

TYPE: new feature

KEYWORDS: new Tiedtke cu scheme, scale aware option

SOURCE: internal

DESCRIPTION OF CHANGES:
A scale-aware or grid-distance-dependent option is added to the new Tiedtke scheme. The code is based on the paper by Wang (2022), and can be turned on by using namelist option ntiedtke_dx_opt = 1. The option becomes active when grid sizes is less than 15 km.
Wang, W., 2022: Forecasting Convection with a “Scale-Aware” Tiedtke Cumulus Parameterization Scheme at Kilometer Scales. Wea. Forecasting, 37/8, 1491 - 1507, 10.1175/WAF-D-21-0179.1.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M dyn_em/module_first_rk_step_part1.F
M phys/module_cu_ntiedtke.F
M phys/module_cumulus_driver.F
M run/README.namelist

TESTS CONDUCTED:

Do mods fix problem? How can that be demonstrated, and was that test conducted?
The Jenkins tests have passed.

RELEASE NOTE: A scale-aware or grid-distance-dependent option is added to the new Tiedtke scheme. The code is based on the paper by Wang (2022), and can be turned on by using namelist option ntiedtke_dx_opt = 1. The option becomes active when grid sizes is less than 15 km.

weiwangncar · 2023-01-11T08:52:44Z

@ChunxiZhang-NOAA Thanks for agreeing to add this code to the WRF repository. Can you please review this PR and state your approval or otherwise? Thanks!

weiwangncar · 2023-01-11T09:21:46Z

The Jenkins test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

ChunxiZhang-NOAA · 2023-01-11T14:28:50Z

phys/module_cu_ntiedtke.F

@@ -191,6 +192,7 @@ subroutine cu_ntiedtke( &
 !-- dz8w dz between full levels (m)
 !-- qfx upward moisture flux at the surface (kg/m^2/s)
 !-- hfx upward heat flux at the surface (w/m^2) 
+!-- ntiedtke_dx_opt whether the schemem is scale-aware


Would be great if the annotation could be something like "option (switch) for scheme scale-dependency"

I agree, the name could be better too

...but I see NSAS has a similar name, so it may be OK

I did base this namelist name on nsas option. I was surprised that it didn't refer it as scale-aware.

phys/module_cu_ntiedtke.F

ChunxiZhang-NOAA · 2023-01-11T14:39:23Z

phys/module_cu_ntiedtke.F

 ztau = max(ztmst,ztau)
 ztau = max(360.,ztau)
+ if(ntiedtke_dx_opt.eq.1) then
+ ztau = min(43200.,ztau)
+ else
 ztau = min(10800.,ztau)


indent here

ChunxiZhang-NOAA · 2023-01-11T15:10:13Z

phys/module_cu_ntiedtke.F

 !--------------------------------
 !* 1. specify parameters
 !--------------------------------
 zcons2=3./(g*ztmst)
 zfacbuo = 0.5/(1.+0.5)
+ if(ntiedtke_dx_opt.eq.1) then
+ zprcdgw = cprcon*zrg/(scale_fac(jl)**(1./3.))


indent here

ChunxiZhang-NOAA

Approved with some minor changes

dudhia · 2023-01-12T16:18:35Z

phys/module_cu_ntiedtke.F

+ if (dx(j).lt.dxref .and. ntiedtke_dx_opt.eq.1) then
+ scale_fac(j) = (1.+log(dxref/dx(j)))**3
+ else
+ scale_fac(j) = 1.+1.33e-5*dx(j)


I think this function is discontinuous at 15 km.

also this function increases with dx > 15 km and decreases when < 15 km

@dudhia Here are two plots of the scale factors: The first has two lines one for each of the scale_fac equations (red is the new one).

The second one is an enlarged one for the lower values of scale_fac, so that you can see the two functions when it crosses 15 km. I would argue that the continuity isn't bad. The original function does increases with DX, but it changes only very slightly with DX.

dudhia · 2023-01-12T16:21:03Z

phys/module_cu_ntiedtke.F

 !--------------------------------
 !* 1. specify parameters
 !--------------------------------
 zcons2=3./(g*ztmst)
 zfacbuo = 0.5/(1.+0.5)
+ if(ntiedtke_dx_opt.eq.1) then
+ zprcdgw = cprcon*zrg/(scale_fac(jl)**(1./3.))
+ else


Why is scale_fac defined as the cube of something and then used as the cube root?

I see now it is used in other places.

also in the paper I think it says square root?

@dudhia Thanks for pointing it out. That is an error in the paper. It is the cubic root that has been used in the code.

dudhia · 2023-01-13T16:13:28Z

The calculated value isn't the same at 15 km and then it increases again slowly after that. I also find 15/dx matches your function very closely from 3-15 km, and would have been much simpler.

…

On Thu, Jan 12, 2023 at 7:40 PM weiwangncar ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In phys/module_cu_ntiedtke.F <#1806 (comment)>: > @@ -585,6 +590,18 @@ subroutine tiecnvn(pu,pv,pt,pqv,pqc,pqi,pqvf,ptf,poz,pzz,pomg, & integer i,j,k,lq,km,km1 real dt,ztpp1 real zew,zqs,zcor + real scale_fac(lq), dxref +! +! set scale-dependency factor when dx is < 15 km +! + dxref = 15000. + do j=1,lq + if (dx(j).lt.dxref .and. ntiedtke_dx_opt.eq.1) then + scale_fac(j) = (1.+log(dxref/dx(j)))**3 + else + scale_fac(j) = 1.+1.33e-5*dx(j) @dudhia <https://github.com/dudhia> Here are two plots of the scale factors: The first has two lines one for each of the scale_fac equations (red is the new one). [image: scale1] <https://user-images.githubusercontent.com/12705680/212224032-4a71232b-6883-4f24-99b1-cfe85b4300ef.png> The second one is an enlarged one for the lower values of scale_fac, so that you can see the two functions when it crosses 15 km. I would argue that the continuity isn't bad. The original function does increases with DX, but it changes only very slightly with DX. [image: scale2] <https://user-images.githubusercontent.com/12705680/212224436-c8832660-d5b9-4b9e-90b3-626f035cfd69.png> — Reply to this email directly, view it on GitHub <#1806 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77FHQT5X7QKJ475INHTWSC6CVANCNFSM6AAAAAATXYLFXQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

dudhia

Still a bit iffy about the slight discontinuity of function at 15 km - can address later

weiwangncar · 2023-01-20T06:14:38Z

@ChunxiZhang-NOAA Can you approve this PR again? Thanks.

weiwangncar · 2023-01-21T06:46:40Z

@smileMchen Can you help Chunxi to approve this PR? Somehow his approval is not registered. Thanks!

kkeene44 · 2023-01-24T00:12:45Z

@ChunxiZhang-NOAA
I'll approve this PR.

…1806) Add scale-aware to the new Tiedtke scheme as an option TYPE: new feature KEYWORDS: new Tiedtke cu scheme, scale aware option SOURCE: internal DESCRIPTION OF CHANGES: A scale-aware or grid-distance-dependent option is added to the new Tiedtke scheme. The code is based on the paper by Wang (2022), and can be turned on by using namelist option ntiedtke_dx_opt = 1. The option becomes active when grid sizes is less than 15 km. Wang, W., 2022: Forecasting Convection with a “Scale-Aware” Tiedtke Cumulus Parameterization Scheme at Kilometer Scales. _Wea. Forecasting_, 37/8, 1491 - 1507, 10.1175/WAF-D-21-0179.1. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M dyn_em/module_first_rk_step_part1.F M phys/module_cu_ntiedtke.F M phys/module_cumulus_driver.F M run/README.namelist TESTS CONDUCTED: 1. Do mods fix problem? How can that be demonstrated, and was that test conducted? 2. The Jenkins tests have passed. RELEASE NOTE: A scale-aware or grid-distance-dependent option is added to the new Tiedtke scheme. The code is based on the paper by Wang (2022), and can be turned on by using namelist option ntiedtke_dx_opt = 1. The option becomes active when grid sizes is less than 15 km.

Add scale-aware option to the new Tiedtke cu scheme

dc85bf9

weiwangncar requested review from a team as code owners January 11, 2023 08:45

ChunxiZhang-NOAA reviewed Jan 11, 2023

View reviewed changes

phys/module_cu_ntiedtke.F Outdated Show resolved Hide resolved

ChunxiZhang-NOAA reviewed Jan 11, 2023

View reviewed changes

ChunxiZhang-NOAA previously approved these changes Jan 11, 2023

View reviewed changes

add indentation

bb5258c

weiwangncar dismissed ChunxiZhang-NOAA’s stale review via bb5258c January 12, 2023 02:35

dudhia reviewed Jan 12, 2023

View reviewed changes

dudhia added the Develop Branch label Jan 19, 2023

dudhia approved these changes Jan 19, 2023

View reviewed changes

ChunxiZhang-NOAA approved these changes Jan 20, 2023

View reviewed changes

kkeene44 approved these changes Jan 24, 2023

View reviewed changes

weiwangncar merged commit 7639166 into wrf-model:develop Jan 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scale-aware to the new Tiedtke cu scheme as an option #1806

Add scale-aware to the new Tiedtke cu scheme as an option #1806

weiwangncar commented Jan 11, 2023 •

edited

Loading

weiwangncar commented Jan 11, 2023

weiwangncar commented Jan 11, 2023

ChunxiZhang-NOAA Jan 11, 2023 •

edited

Loading

dudhia Jan 11, 2023 •

edited

Loading

dudhia Jan 11, 2023

weiwangncar Jan 12, 2023

ChunxiZhang-NOAA Jan 11, 2023

weiwangncar Jan 12, 2023

ChunxiZhang-NOAA Jan 11, 2023

weiwangncar Jan 12, 2023

ChunxiZhang-NOAA left a comment

dudhia Jan 12, 2023

dudhia Jan 12, 2023

weiwangncar Jan 13, 2023

dudhia Jan 12, 2023

dudhia Jan 12, 2023

dudhia Jan 12, 2023

weiwangncar Jan 13, 2023

dudhia commented Jan 13, 2023 via email

dudhia left a comment

weiwangncar commented Jan 20, 2023

weiwangncar commented Jan 21, 2023

kkeene44 commented Jan 24, 2023

Add scale-aware to the new Tiedtke cu scheme as an option #1806

Add scale-aware to the new Tiedtke cu scheme as an option #1806

Conversation

weiwangncar commented Jan 11, 2023 • edited Loading

weiwangncar commented Jan 11, 2023

weiwangncar commented Jan 11, 2023

ChunxiZhang-NOAA Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

dudhia Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChunxiZhang-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dudhia commented Jan 13, 2023 via email

dudhia left a comment

Choose a reason for hiding this comment

weiwangncar commented Jan 20, 2023

weiwangncar commented Jan 21, 2023

kkeene44 commented Jan 24, 2023

weiwangncar commented Jan 11, 2023 •

edited

Loading

ChunxiZhang-NOAA Jan 11, 2023 •

edited

Loading

dudhia Jan 11, 2023 •

edited

Loading