Add missing oops for CLM plus urban check #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reg tests have passed: |
|
Might have to restrict it to just Noah and NoahMP for urban options. |
dudhia
approved these changes
Dec 7, 2022
|
@smileMchen @kkeene44 Can one of you approve this PR if it looks good to you? |
kkeene44
approved these changes
Dec 8, 2022
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: Bug fix KEYWORDS: clm, urban cross check SOURCE: reported by Shuhua Chen, UC Davis, internal DESCRIPTION OF CHANGES: Problem: Error check variable oops is not incremented when urban options are checked against land model option CLM. Solution: Increment variable oops to correct the error. LIST OF MODIFIED FILES: M share/module_check_a_mundo.F TESTS CONDUCTED: 1. Yes. Model gracefully stops when both CLM and an urban option are selected. 2. The Jenkins tests are all passing. RELEASE NOTE: Model will stop if both CLM and an urban physics option are selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: clm, urban cross check
SOURCE: reported by Shuhua Chen, UC Davis, internal
DESCRIPTION OF CHANGES:
Problem:
Error check variable oops is not incremented when urban options are checked against land model option CLM.
Solution:
Increment variable oops to correct the error.
LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F
TESTS CONDUCTED:
RELEASE NOTE: Model will stop if both CLM and an urban physics option are selected.