Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need check_a_mundo test: max_ts_level must be <= number of znu half layers #976

Closed
davegill opened this issue Aug 23, 2019 · 1 comment
Closed

Need check_a_mundo test: max_ts_level must be <= number of znu half layers #976

davegill opened this issue Aug 23, 2019 · 1 comment

Comments

@davegill
Copy link
Contributor

From Pedro Jimenez

I found that max_ts_level should not be set to a number larger than the number of half levels. If the user accidentally set this namelist entry to a larger value, then the wrf_timeseries.F tries to use w_2 and other vars at higher levels than possible. The model would not crash but I do not know what would happen to the time series results. I found this compiling WRF in debugging mode since I set up max_ts_level to the number of full levels. Unfortunately I removed the log file with the error.

There should be a check maybe in check_a_mundo to ensure that max_ts_level is not set up to a number higher than the number of half levels.
@smileMchen
Copy link
Collaborator

This issue has been addressed and is closed.

@smileMchen smileMchen mentioned this issue Aug 23, 2019
Merged
davegill pushed a commit that referenced this issue Nov 20, 2019
@smileMchen @davegill
max_ts_level should be .LE. the number of half levels (#977)
cdf5052 
TYPE: bug fix

KEYWORDS: max_ts_level

SOURCE: Pedro Jimenez Munoz (RAL/MMM), internal

DESCRIPTION OF CHANGES: 
The value of `max_ts_level` should be set less than or equal to the number of half levels. If 
`max_ts_level` is accidentally set to a larger value, the wrf_timeseries.F would try to access 
the vertical velocity (`w_2`) and other variables that are defined on full levels with an index 
outside of the variables' extent.  A check is added to check_a_mundo to ensure that if 
`max_ts_level` is  set up to a number larger than the number of half layers, then it is reset to 
the number of half layers.

ISSUE:
Fixes #976 "Need check_a_mundo test: max_ts_level must be <= number of znu half layers"

LIST OF MODIFIED FILES:
M    share/module_check_a_mundo.F
M    run/README.tslist 

TESTS CONDUCTED: 
1. A single test is run to ensure the check works as expected. Below is the output:

```
Quilting with   1 groups of   0 I/O tasks.
 Ntasks in X            6 , ntasks in Y            6
   max_ts_level must be <= number of znu half layers
   max_ts_level is reset to the number of znu half layers
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davegill @smileMchen