Add missing OAuth constants #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcarvelli
commented
Jun 17, 2024
| [null, null, Resource\ConnectionType::GoogleOAuth, null], | ||
| [null, null, Resource\ConnectionType::MicrosoftOAuth, null], |
There was a problem hiding this comment.
Seeing this test fail with AppleOAuth helped me find the $supportedProviders array above. Doesn't hurt to run it for all our social logins.
mthadley
approved these changes
Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
AppleOAuthconstants so SDK users can kick off login flows with Sign in with Apple.The
GitHubOAuthand 'MicrosoftOAuth` constants were partially missing, adding them too.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.