Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with "awe" #33

Closed
wants to merge 1 commit into from
Closed

Fix issue with "awe" #33

wants to merge 1 commit into from

Conversation

tscole
Copy link

@tscole tscole commented Jun 14, 2019

awe should be counted as one syllable not two

awe should be counted as one syllable not two
@wooorm
Copy link
Member

wooorm commented Jul 2, 2019

@tscole Thanks for the PR and sorry for the wait! Unfortunately fixing this isn’t as trivial as this change: the CI is failing, because other words now get the wrong syllable count. If you can find the time, could you try again? And add some tests?

Note: you can run something like sed -n '/^awe/p' < /usr/share/dict/words if you’re on unix (such as a mac) to find words that match this prefix.

@wooorm
Copy link
Member

wooorm commented Jul 26, 2019

@tscole ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants