Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Columns block renders more than two columns in a row when launching in landscape mode #2407

Merged
merged 3 commits into from
Jun 19, 2020
Merged

[Fix] Columns block renders more than two columns in a row when launching in landscape mode #2407

merged 3 commits into from
Jun 19, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Jun 19, 2020

Fixes #2405
Gutenberg PR - WordPress/gutenberg#23305

To test:

  • Make sure that your editor has more than two columns in a columns block
  • Turn the device or emulator in landscape mode
  • Start the Gutenberg-Mobile app or reload
  • Observe that max two columns are rendered in each row
  • Switch to the portrait mode
  • Only one column should be rendered in a row

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 19, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dratwas dratwas mentioned this pull request Jun 19, 2020
Merged
6 tasks
@dratwas dratwas changed the title Fix/columns in row [Fix] Columns block renders more than two columns in a row when launching in landscape mode Jun 19, 2020
pinarol
pinarol approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dratwas dratwas merged commit 0538376 into develop Jun 19, 2020
@dratwas dratwas deleted the fix/columns-in-row branch June 19, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: Columns block renders more than two columns in a row when launching in landscape mode
2 participants
@dratwas @pinarol