Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slider to reflect changes immediately #2286

Closed
wants to merge 4 commits into from

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented May 21, 2020

Fixes #2192
Gutenberg PR: WordPress/gutenberg#22421

To test:
1.

  • open mobile app
  • add spacer block
  • open settings of the spacer block
  • change the height of spacer - change should be visible while moving the slider
  • add button block
  • open settings of that button
  • change the border-radius - change should be visible while moving the slider

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 21, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@geriux geriux added this to the 1.30 milestone May 28, 2020
@geriux geriux added the Blocks label May 28, 2020
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#22421 (review)

Just one thing about the release notes.

@dratwas dratwas force-pushed the feat/update-slider-immediately branch 2 times, most recently from 507f5f3 to b0f9d27 Compare June 4, 2020 09:17
@mchowning
Copy link
Contributor

We're preparing to cut the 1.30 release branches now. Let's merge this ASAP or update the milestone to 1.31.

@dratwas
Copy link
Contributor Author

dratwas commented Jun 9, 2020

Hey @mchowning, unfortunately, we had to revert the PR that fixed the issue with creating undo levels when using the slider. WordPress/gutenberg#22933

The issue is described here #2192 (comment)

I'm moving it to the milestone 1.31

@dratwas dratwas modified the milestones: 1.30, 1.31 Jun 9, 2020
@mchowning
Copy link
Contributor

mchowning commented Jun 18, 2020

👋 @dratwas! We're close to merging the monorepo changes 🎉 , and we will be cutting the release branches as soon as the monorepo changes are merged to gutenberg-mobile. As a result, we may be cutting the 1.31 release branches earlier than normal.

Because every merge further delays the monorepo work (ends up requiring conflicts to be fixed and other work due to the monorepo feature branch and the squash policy in gutenberg), we want to cut the release branch with no further changes. For that reason, I'll bump this milestone to 1.32. Of course, if this has to make the 1.31 release, go ahead and move it back to the 1.31 milestone, and let me know. 🙇

@mchowning mchowning modified the milestones: 1.31, 1.32 Jun 18, 2020
@mchowning
Copy link
Contributor

👋 @dratwas ! We're getting ready to cut the 1.32 release branch, so I'm bumping this to the 1.33 milestone. If this needs to make the 1.32 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇

@mchowning mchowning modified the milestones: 1.32, 1.33 Jul 7, 2020
@dratwas
Copy link
Contributor Author

dratwas commented Jul 7, 2020

Hey @mchowning thanks for the heads up i need to wait for the wordpress-mobile/WordPress-Android#12144 with this one.

@SergioEstevao
Copy link
Contributor

👋 @dratwas ! We're getting ready to cut the 1.33 release branch, so I'm bumping this to the 1.34 milestone. If this needs to make the 1.33 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇

@SergioEstevao SergioEstevao modified the milestones: 1.33, 1.34 Jul 20, 2020
@ceyhun
Copy link
Contributor

ceyhun commented Aug 3, 2020

👋 @dratwas ! We're getting ready to cut the 1.34 release branch, so I'm bumping this to the 1.35 milestone. If this needs to make the 1.35 release though, go ahead and change the milestone back and try to get this merged as soon as possible. If you're trying to get this into the release, please also let us know in Slack. 🙇

@ceyhun ceyhun modified the milestones: 1.34, 1.35 Aug 3, 2020
@dratwas dratwas force-pushed the feat/update-slider-immediately branch from b0f9d27 to 417414b Compare August 11, 2020 14:59
@ceyhun
Copy link
Contributor

ceyhun commented Aug 14, 2020

@dratwas heads up we'll be cutting the 1.35 release branch beginning of next week. Please try to get this merged by than or bump the milestone 🙇

@cameronvoell
Copy link
Contributor

@dratwas heads up we'll be cutting the 1.35 release branch beginning of next week. Please try to get this merged by than or bump the milestone 🙇

Bumping milestone

@cameronvoell cameronvoell modified the milestones: 1.35, 1.36 Aug 18, 2020
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
@dratwas dratwas force-pushed the feat/update-slider-immediately branch from cd6ebcc to 794bba5 Compare August 24, 2020 09:27
@cameronvoell
Copy link
Contributor

@dratwas not sure if this PR is needed for package.json updates, or if we can close it since I believe the gutenberg side is already merged and updated in gb-mobile develop. If you want to merge this one, I think merging in develop should fix CI (fix PR - #2571).

I'll cut the branches for 1.36 later in the day on Monday 8/31, see please merge before then if needed, thanks!

@dratwas
Copy link
Contributor Author

dratwas commented Aug 31, 2020

Closing since these changes are merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Slider to reflect changes immediately
6 participants