Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix Gallery caption overlapped by other block #2033

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix: Fix Gallery caption overlapped by other block #2033

merged 2 commits into from
Mar 18, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Mar 18, 2020 •
edited
Loading

Fixes #2031

Gallery caption gets covered by another block border.

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

To test:

  1. Add Gallery block
  2. Add gallery caption
  3. Start adding new block, changing order and selection
  4. See that Gallery caption is not being overlapped by next block border

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda added the bugfix label Mar 18, 2020
@jbinda jbinda requested a review from geriux March 18, 2020 12:22
@jbinda jbinda self-assigned this Mar 18, 2020
@jbinda jbinda mentioned this pull request Mar 18, 2020
Merged
6 tasks
geriux
geriux approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20987 (review)

@jbinda jbinda merged commit ae8853f into develop Mar 18, 2020
@jbinda jbinda mentioned this pull request Mar 18, 2020
Merged
7 tasks
@jbinda jbinda deleted the callstack/fix-gallery-caption branch March 25, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@jbinda jbinda

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery caption is overlapped by other blocks
2 participants
@jbinda @geriux