Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member, GroupMember, MemberGroup 엔티티 재설계 #1605

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Member, GroupMember, MemberGroup 엔티티 재설계 #1605

merged 5 commits into from
Oct 18, 2023

Conversation

wonyongChoi05
Copy link
Member

#️⃣연관된 이슈

#1559

변경 사항

  • 기존의 GroupMember -> DepartmentMember, MemberGroup -> Department로 변경되었습니다. 그리고 해당 엔티티들의 필드 이름도 같이 변경되었습니다.
  • name, description -> part(포지션 ex: 백엔드, 프론트엔드..), term(ex: 1기, 2기 ..)
  • flyway 스크립트 작성했습니다(v9)

💬리뷰 요구사항(선택)

  • 현재 클라이언트에서 course라는 이름으로 part를 받아오는데 추후 클라이언트랑 합의해서 용어를 통일했으면 좋겠습니다.

@wonyongChoi05 wonyongChoi05 added BE 고도화 고도화 스쿼드 관련 이슈 labels Oct 13, 2023
@wonyongChoi05 wonyongChoi05 linked an issue Oct 13, 2023 that may be closed by this pull request
Member, GroupMember, MemberGroup 엔티티 재설계 #1559
Closed
@e-astsea
Copy link
Member

👍

This2sho
This2sho approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@This2sho This2sho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

94.9% 94.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wonyongChoi05 wonyongChoi05 changed the base branch from main to develop October 18, 2023 07:35
@wonyongChoi05 wonyongChoi05 merged commit d0ec8fc into develop Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@This2sho This2sho This2sho approved these changes

@hong-sile hong-sile Awaiting requested review from hong-sile

@splitCoding splitCoding Awaiting requested review from splitCoding

@e-astsea e-astsea Awaiting requested review from e-astsea

Assignees

@This2sho This2sho

@mcodnjs mcodnjs

@wonyongChoi05 wonyongChoi05

Labels
BE 고도화 고도화 스쿼드 관련 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member, GroupMember, MemberGroup 엔티티 재설계
4 participants
@wonyongChoi05 @e-astsea @This2sho @mcodnjs