-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[둘리] 1, 2단계 영화 티켓 예매 제출합니다. #7
Merged
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
81ab027
docs: 클래스와 액티비티 설계도 작성
whk06061 545de51
feat: Movie 데이터 클래스 작성
whk06061 766d546
docs: 설계도 수정
whk06061 4c79b1a
feat: Price 클래스 구현
whk06061 4396e2c
feat: TicketingInfo 클래스 구현
whk06061 282882b
refactor: TicketingInfo name->title로 수정
whk06061 4690eae
feat: ListView, ListAdapter 구현
whk06061 2bc5a77
feat: 문자열 상수 @string으로 분할
whk06061 15cf193
feat: MovieListActivity 구현
whk06061 c75d5a7
feat: activity_ticketing xml 구현
whk06061 e38faa0
refactor: xml 더미데이터 삭제
whk06061 2616c9a
refactor: Price 클래스 value class 로 변경
whk06061 7c5e91f
feat: TicketingActivity 구현
whk06061 761850e
feat: activity_movie_ticket xml 구현
whk06061 013a294
feat: MovieTicketActivity 구현
whk06061 adf25b7
refactor: activity_movie_ticket.xml 글자 볼드 처리 수정
whk06061 f50a2ce
refactor: ViewHolder 적용
whk06061 48a66c5
refactor: 불필요한 MainActivity 삭제
whk06061 47f12c8
refactor: 상영일, 러닝타임 문자 출력 수정
whk06061 443e903
refactor: activity_ticketing.xml 본문 스크롤 되도록 수정
whk06061 e7db664
docs: 클래스 설계도 수정
whk06061 aa74fa9
feat: PlayingTimes 구현
whk06061 c05ff0e
refactor: PlayintDate, PlayingTime 따로 받도록 수정
whk06061 fc093c7
refactor: 직렬화되도록 수정
whk06061 3f5cc8f
feat: 날짜 시간 선택 spinner 구현
whk06061 b512714
feat: 할인 정책 구현
whk06061 6d2199c
feat: 화면 회전 시 데이터 유지 구현
whk06061 520d74b
refactor: 영화 더미 데이터 가져오는 함수 분리
whk06061 3ddf00b
refactor: 로직 함수로 분리
whk06061 fe47ef3
feat: Formatter 구현
whk06061 5525f7b
feat: Intent getSerializable 확장함수 구현
whk06061 7dce42c
refactor: MovieListAdapter, MovieTicketActivity 리팩터링
whk06061 70e7f6b
test: FormatterTest 구현
whk06061 6b3843c
refactor: TicketingActivity.kt 코드 리팩토링
whk06061 c881fba
refactor: 패키지 구조 분리 및 액티비티 명 수정
whk06061 4d17d10
refactor: SpinnerListener, Keys 분리
hyemdooly 10f416c
refactor: DummyData 분리
hyemdooly 303b877
refactor: getString 필요없는 format 함수 사용 삭제
hyemdooly ed85463
refactor: require 수정
hyemdooly 452126c
refactor: ViewHolder 필드들 nullable인 것 수정
hyemdooly 77afa95
refactor: PlayingTimes 리팩터링
hyemdooly 54b5c30
fix: Exception 발생 버그 수정
hyemdooly 8609c35
refactor: Policies 따로 분할, 범용적으로 사용할 수 있도록 수정
hyemdooly 2e67294
test: DiscountPolicy 클래스 변경으로 인한 테스트 수정 및 추가
hyemdooly 187af84
refactor: Formatter 삭제
hyemdooly 6fc6324
refactor: 모든 layout Linear에서 Constraint로 변경
hyemdooly a5e2e98
refactor: ktlintFormat 적용
hyemdooly 37cf719
refactor: FormatterTest 삭제
hyemdooly b8c06a2
refactor: null일시 토스트 띄운 후 뒤로가도록 수정
hyemdooly e2c4c55
refactor: 확장함수명 변경
hyemdooly 0fe291d
refactor: 패키지 변경 및 뷰 값 세팅 클래스 분리
hyemdooly dc6ad79
refactor: 패키지 변경
hyemdooly e062f6f
refactor: MovieDetailActivity, TicketResultActivity 함수 분리
hyemdooly 9864e56
refactor: DummyData 추가, 변수명 변경
hyemdooly 5cca9a1
refactor: MovieDTO 추가
hyemdooly a45c442
refactor: Key들 위치 변경, Keys object 삭제
hyemdooly 9f8e452
refactor: 확장함수명 변경
hyemdooly d04bd6c
refactor: else문 삭제
hyemdooly 5336de6
refactor: scope function run 대신 with 사용
hyemdooly 77cd778
refactor: package 이동, MovieDTO 및 Mapper 수정
hyemdooly 1c36e77
refactor: view를 객체 내부에서 찾도록 변경
hyemdooly 186d6f6
refactor: key가 없으면 빈 리스트를 반환하는 Map 확장함수 구현
hyemdooly b1bffce
refactor: 모듈 분리
hyemdooly b13a913
refactor: ViewHolders Map 생성, set 함수 이동
hyemdooly f8c3245
refactor: MovieListItemListener 생성 후 Listener 분할
hyemdooly ae36175
refactor: getKeyFromIndex Map 확장함수 생성
hyemdooly f2bfce9
refactor: MovieDTO -> MovieModel 네이밍 변경
hyemdooly 1dc76f1
refactor: View Setting 함수 하나로 합치기
hyemdooly ac7b7e6
refactor: SpinnerAdapter 함수 분리
hyemdooly 39215c6
refactor: TicketingInfo -> Ticket으로 변경, payment 삭제
hyemdooly b89051c
refactor: TicketModel 생성, 도메인 객체 의존성 제거
hyemdooly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: View Setting 함수 하나로 합치기
- Loading branch information
commit 1dc76f14f9a3511ac5658433ffd18ef8636e66e0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set을 할 때마다 findViewId를 실행해주어야겠네요.
한 번만 해보는 방법도 있겠네요 :)