Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[둘리] 1, 2단계 영화 극장 선택 제출합니다. #4
[둘리] 1, 2단계 영화 극장 선택 제출합니다. #4
Changes from 31 commits
e0afc94
7026a40
74deaf3
b2ef721
8135b14
4f8255a
add9dd3
40fcc29
44bf562
cca69f7
a508eaa
1592c3d
f5a9ef9
9737d18
939d84a
76e9b00
beb0b3a
b71eb97
7a8b6b9
070cce4
8497d53
b2ce59d
fcd527f
c9df85d
8eba6d0
085e9dd
fd3e4d3
17cafbc
b634aa8
72e7a58
00f4a8f
923eedd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프래그먼트가 보인다를 테스트해야 하는데, 실제로 해당 프래그먼트의 컨텐츠를 확인하는게 아쉽네요..
저도 프래그먼트 테스트는 자주 해보지 않아서, 어떤 방식이 최적의 방식인지는 추천드리기 어려운데
프래그먼트 매니저를 이용해서 프래그먼트의 인스턴스가 해당 타입이 맞는지 확인하는게 가능할까 싶네요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TAG로 프래그먼트를 가져와서 그 프래그먼트가 visible인지 검사했습니다! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래 내용은 꼭 반영하지 않으셔도 됩니다.
세팅 화면에서 UI 테스트를 하기 위해 프리퍼런스가 잘 동작하는지를 체크하는게 맞을까? 라는 의문이 들었어요.
만약 프리퍼런스가 아닌 데이터베이스로 바뀌면 UI 테스트가 같이 실패하게 됩니다.
객체지향 관점으로 접근해 보면, 어떤 방법으로 데이터를 가져오는지 관심 없도록 만들어 볼 수도 있겠네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let에 대한 올바른 사용 방법이 아닙니다.
코틀린에서 제공하는 범위 함수를 어떤 상황에서 사용하는지는 조금씩 다르지만, 단순히 변수 줄이는 목적처럼 사용하지는 않습니다.
https://kotlinlang.org/docs/scope-functions.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반복되는 코드가 보이면 어떻게 해야 한다!?
This file was deleted.