Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[둘리] 3, 4단계 영화 극장 선택 제출합니다. #31

Merged
merged 90 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
c75c7cc
refactor(AlarmController, AlarmReceiver): 중복 코드 제거, scope function 사용 수정
hyemdooly Apr 29, 2023
af1eb2c
refactor(MovieListFragment): Mock이 아닌 인터페이스로 타입 수정
hyemdooly Apr 29, 2023
03aed6f
feat(SettingDataManager): Setting값을 관리하는 인터페이스, 프리퍼런스를 관리하는 클래스 구현
hyemdooly Apr 29, 2023
35e4978
feat(AlarmController): 채널 관리, 알람 설정 AlarmController로 함수 이동
hyemdooly Apr 29, 2023
af6ad6c
refactor(MovieMainActivity): TAG 상수 위치 이동
hyemdooly Apr 30, 2023
29edef5
refactor(MovieMainActivityTest): 프래그먼트 자체를 확인하는 직관적인 테스트 코드로 변경
hyemdooly Apr 30, 2023
bb6cca9
feat(SettingFragmentTest): UI 중심으로 프래그먼트 테스트 재작성 (토글값 유지)
hyemdooly Apr 30, 2023
b95885c
refactor(SettingFragment): MVP 리팩터링
hyemdooly May 2, 2023
a3fb3df
feat(AlarmManageable): AlarmController의 인터페이스 생성
hyemdooly May 2, 2023
163fb80
refactor(SettingPresenter, SettingContract): MVP 리팩터링, 추상화
hyemdooly May 2, 2023
77d3cc2
refactor(ReservationListFragment): MVP 리팩터링
hyemdooly May 2, 2023
42ef79c
refactor(MovieListFragment): MVP 리팩터링
hyemdooly May 3, 2023
de04d9b
refactor(ReservationActivity): 패키지명 변경
hyemdooly May 3, 2023
fc72a83
refactor(Movie): 로직 도메인 로직으로 이동
hyemdooly May 3, 2023
f36a118
refactor(Ktlint): KtlintFormat
hyemdooly May 3, 2023
11e4cc5
refactor(ReservationActivity): MVP 리팩터링
hyemdooly May 3, 2023
ceb7db9
refactor(package): 패키지명 변경
hyemdooly May 3, 2023
65b95f1
refactor(domain, SeatSelectionAcitivty): 도메인, 좌석 지정 코드 전체 리팩터링
hyemdooly May 3, 2023
7ef5f63
refactor(domain, SeatSelectionAcitivty): 도메인, 좌석 지정 코드 전체 리팩터링
hyemdooly May 4, 2023
cddae6d
refactor(SeatSelectionActivity): MVP 리팩터링
hyemdooly May 4, 2023
a77b368
feat(Theater): 극장 정보 클래스 생성
hyemdooly May 4, 2023
72f31b4
refactor(Movie, ScreeningDateTimes): Movie 프로퍼티 변경, ScreeningDateTime…
hyemdooly May 4, 2023
877910d
refactor(MovieListFragment): MovieListFragment 리팩터링
hyemdooly May 4, 2023
08e3b4d
refactor(ReservationActivityTest, SeatSelectionActivityTest): 리팩터링에 따…
hyemdooly May 4, 2023
7d5e406
refactor(ReservationCompletedActivity): 예약 확정 액티비티 MVP 리팩터링
hyemdooly May 4, 2023
7e57cc1
refactor(SettingFragment): 세팅 화면 리팩터링
hyemdooly May 4, 2023
20cf636
refactor(domain): 영화관 상영 정보 추가에 따른 도메인 구조 변경
hyemdooly May 4, 2023
8ddcb4b
refactor(Movie, Schedule): Schedule 클래스 생성, Movie 프로퍼티 변경
hyemdooly May 5, 2023
ba9cd66
refactor(MovieUiModel, MoviePosterRepository): MovieUiModel, MoviePos…
hyemdooly May 5, 2023
ef15f75
refactor(Movie, Schedule): 도메인 모델 구조 변경
hyemdooly May 5, 2023
7fb897e
feat(TheaterBottomSheetFragment): 극장 선택 구현
hyemdooly May 5, 2023
a4225fd
feat(ReservationActivity): 도메인 모델 수정에 따른 수정
hyemdooly May 5, 2023
0f0ace2
refactor(ReservationActivity): 확장함수 정의로 인한 리팩터링
hyemdooly May 5, 2023
c2f8181
fix(ReservationPresenter): 카운터 초기값 0 -> 1 수정
hyemdooly May 5, 2023
4addfaf
refactor(SeatSelectionActivity): 극장 정보 추가에 따른 리팩터링 및 추가 구현
hyemdooly May 5, 2023
417b7f9
feat(ReservationCompleted): 예매 완료 화면 극장 정보 추가 구현
hyemdooly May 5, 2023
8a17d92
refactor(TheaterMockRepository, MovieMockRepository): 아주 긴 극장 이름 확인용 …
hyemdooly May 5, 2023
b90ce79
feat(ReservationDbRepository): 데이터베이스 구현
hyemdooly May 6, 2023
20eb29d
test(ReservationActivityTest, SeatSelectionActivityTest): 도메인 모델 수정에 …
hyemdooly May 6, 2023
3278e8f
refactor(MovieListPresenter): Repository 추상화 의존성 주입, 패키지명 변경
hyemdooly May 6, 2023
5ee3bdc
test(MovieListPresenterTest): MovieListPresenterTest 구현
hyemdooly May 6, 2023
09c3ba2
test(ReservationListPresenterTest): ReservationListPresenterTest 구현
hyemdooly May 6, 2023
3a43ad8
test(ReservationPresenterTest): ReservationPresenterTest 구현
hyemdooly May 6, 2023
009cb87
test(SettingPresenterTest): SettingPresenterTest 구
hyemdooly May 6, 2023
11b2fc7
test(ReservationCompletedPresenterTest): ReservationCompletedPresente…
hyemdooly May 6, 2023
81644ee
test(SeatSelectionPresenterTest): SeatSelectionPresenterTest 구현
hyemdooly May 6, 2023
a64f78e
refactor(SeatSelectionActivity): 필요없는 전역 변수 삭제
hyemdooly May 6, 2023
4815484
refactor(MovieListAdapter): 로그 삭제
hyemdooly May 6, 2023
2611794
refactor(ReservationActivity): 데이터 바인딩 적용
hyemdooly May 6, 2023
3872943
refactor(SeatSelectionActivity): 데이터 바인딩 적용
hyemdooly May 6, 2023
7a0d10e
refactor(ReservationCompletedActivity): 데이터 바인딩 수정
hyemdooly May 6, 2023
7acb0dd
refactor(ReservationActivity): 데이터 바인딩 수정
hyemdooly May 6, 2023
c029161
fix(ReservationDbHelper): split 후 공백 제거
hyemdooly May 6, 2023
86d71bc
refactor(SettingFragment): 데이터 바인딩 적용
hyemdooly May 6, 2023
b6898a7
refactor(MovieListFragment): 데이터 바인딩 적용
hyemdooly May 6, 2023
aff53ce
refactor(TheaterItemViewHolder): 데이터 바인딩 적용
hyemdooly May 6, 2023
a093d1f
refactor(ReservationItemViewHolder): 데이터 바인딩 적용
hyemdooly May 6, 2023
ca87506
refactor(package): test 코드 패키지 이동
hyemdooly May 6, 2023
89b67a2
refactor(PriceSystem): 변수명 통일
hyemdooly May 6, 2023
809e9ae
refactor(package): 패키지 이동, 클래스명 일관성 통일
hyemdooly May 7, 2023
c032ff1
refactor(TheaterMockRepository): requireNotNull 예외처리 적용, 변수 private 변경
hyemdooly May 7, 2023
85205af
refactor(AlarmController): createChannel 함수 private으로 변경
hyemdooly May 7, 2023
131943e
refactor(MovieUiModel): typealias 적용
hyemdooly May 7, 2023
24ece77
refactor(SeatInfoUiModel): 변수명 변경
hyemdooly May 7, 2023
eedd691
refactor(MovieListFragment): MVP 리팩터링
hyemdooly May 7, 2023
14b5219
refactor(ReservationListFragment): MVP 리팩터링
hyemdooly May 7, 2023
3e8df05
refactor(SettingFragment): 필요없는 전역변수 삭제
hyemdooly May 7, 2023
a800192
refactor(SettingFragment): 프로퍼티 최상단으로 이동
hyemdooly May 7, 2023
8add901
refactor(ReservationCompletedActivity): 프로퍼티 최상단으로 이동
hyemdooly May 7, 2023
7ac96e4
refactor(SettingFragment): 인터페이스에서 필요 없는 프로퍼티 삭제
hyemdooly May 7, 2023
6cf0f67
refactor(SettingFragment): 네이밍 변경
hyemdooly May 7, 2023
8582463
refactor(Price): DecimalFormatter 추가 및 수정
hyemdooly May 8, 2023
28b61b8
refactor(ReservationActivity): MVP 리팩터링
hyemdooly May 8, 2023
97afbfe
refactor(SettingFragment): 네이밍 수정
hyemdooly May 8, 2023
3daba24
refactor(SeatSelectinActivity): MVP 리팩터링
hyemdooly May 8, 2023
7bb5bbf
refactor(MovieListAdapter): Inflate 코드 ItemViewHolder 내부로 이동
hyemdooly May 8, 2023
cc79d53
refactor(MapExtension): getKeyFromIndex 함수 제거
hyemdooly May 8, 2023
9a66f21
refactor(Fragments): Fragment가 직접 Fragment를 던지도록 수정
hyemdooly May 8, 2023
b8d4cf1
test(all): 테스트 코드 리팩터링 및 수정으로 인한 코드 변경
hyemdooly May 8, 2023
75e71b5
refactor(MoviePosterRepository): 변경이 적은 코드로 수정
hyemdooly May 8, 2023
a91744a
refactor(SeatSelectionActivity): 프레젠터에서 색상 정보를 제공하도록 변경
hyemdooly May 8, 2023
be39dac
refactor(SeatSelectionActivity): println 삭제, deprecated된 코드 수정
hyemdooly May 8, 2023
b00fa38
fix(SeatSelectionPresenterTest): 테스트 실패 수정
hyemdooly May 8, 2023
ea76ff9
refactor(TheaterMockRepository): requireNotNull 코드 수정
hyemdooly May 8, 2023
c3762e0
refactor(PriceMapper): PriceMapper 삭제
hyemdooly May 8, 2023
ca2af29
refactor(Contract.View): 인터페이스에서 presenter 변수 삭제
hyemdooly May 8, 2023
f39ff1f
refactor(MovieListFragment): presenter 초기화 코드 위치 변경
hyemdooly May 8, 2023
7fb4fbc
refactor(ReservationActivity): 함수 네이밍 변경
hyemdooly May 9, 2023
ed2b736
refactor(TheaterBottomSheetFragment): Bundle로 값을 넘겨주는 방식으로 수정
hyemdooly May 9, 2023
631ecbf
refactor(SeatSelectActivity): SeatInfo 삭제, Theater로 프로퍼티 이동, Presente…
hyemdooly May 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(domain, SeatSelectionAcitivty): 도메인, 좌석 지정 코드 전체 리팩터링
  • Loading branch information
hyemdooly committed May 3, 2023
commit 65b95f108cabec6d3632f8915328ce77a270b95c
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import woowacourse.movie.R
import woowacourse.movie.domain.Minute
import woowacourse.movie.domain.Movie
import woowacourse.movie.domain.movie.Minute
import woowacourse.movie.domain.movie.Movie
import woowacourse.movie.view.mapper.toUiModel
import woowacourse.movie.view.reservation.ReservationActivity
import java.time.LocalDate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import woowacourse.movie.R
import woowacourse.movie.domain.Minute
import woowacourse.movie.domain.Movie
import woowacourse.movie.domain.movie.Minute
import woowacourse.movie.domain.movie.Movie
import woowacourse.movie.view.mapper.toUiModel
import woowacourse.movie.view.model.ReservationOptions
import woowacourse.movie.view.seatselection.SeatSelectionActivity
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package woowacourse.movie.data

import woowacourse.movie.R
import woowacourse.movie.domain.Minute
import woowacourse.movie.domain.Movie
import woowacourse.movie.domain.movie.Minute
import woowacourse.movie.domain.movie.Movie
import woowacourse.movie.domain.repository.MovieRepository
import java.time.LocalDate

Expand Down
26 changes: 26 additions & 0 deletions app/src/main/java/woowacourse/movie/data/Theater.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package woowacourse.movie.data

import woowacourse.movie.domain.policy.MorningPolicy
import woowacourse.movie.domain.policy.MovieDayPolicy
import woowacourse.movie.domain.policy.NightPolicy
import woowacourse.movie.domain.theater.Grade
import woowacourse.movie.domain.theater.TheaterInfo

object Theater {
private val rowGrade = mapOf(
0 to Grade.B,
1 to Grade.B,
2 to Grade.S,
3 to Grade.S,
4 to Grade.A,
)
val row = 5
val col = 4

val info = TheaterInfo(rowGrade, row, col)
val policies = listOf(
MovieDayPolicy(),
MorningPolicy(),
NightPolicy(),
)
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package woowacourse.movie.data.reservation

import woowacourse.movie.domain.Reservation
import woowacourse.movie.domain.repository.ReservationRepository
import woowacourse.movie.domain.reservation.Reservation

object ReservationMockRepository : ReservationRepository {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ class ReservationCompletedActivity : AppCompatActivity() {
peopleCount.text = getString(R.string.reservation_people_count_format)
.format(
getString(R.string.general_person),
reservation.peopleCount,
reservation.count,
reservation.seats.joinToString(),
)
totalPrice.text =
getString(R.string.total_price_format).format(DECIMAL_FORMAT.format(reservation.finalReservationFee))
getString(R.string.total_price_format).format(DECIMAL_FORMAT.format(reservation.count))
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package woowacourse.movie.view.mapper

import woowacourse.movie.domain.Minute
import woowacourse.movie.domain.Movie
import woowacourse.movie.domain.movie.Minute
import woowacourse.movie.domain.movie.Movie
import woowacourse.movie.view.model.MovieListModel.MovieUiModel

fun Movie.toUiModel(): MovieUiModel = MovieUiModel(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package woowacourse.movie.view.mapper

import woowacourse.movie.domain.price.Price
import java.text.DecimalFormat

fun Price.toUiModel(): String {
return DecimalFormat("#,###").format(price)
}
laco-dev marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package woowacourse.movie.view.mapper

import woowacourse.movie.domain.Reservation
import woowacourse.movie.domain.reservation.Reservation
import woowacourse.movie.view.model.ReservationUiModel

fun Reservation.toUiModel(): ReservationUiModel = ReservationUiModel(
movieTitle,
title,
screeningDateTime,
seats.size,
seats.map { it.toUiModel().name },
finalReservationFee.amount
seats.map { it.toUiModel().seatId },
price.price
)
13 changes: 2 additions & 11 deletions app/src/main/java/woowacourse/movie/view/mapper/SeatMapper.kt
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
package woowacourse.movie.view.mapper

import woowacourse.movie.R
import woowacourse.movie.domain.Seat
import woowacourse.movie.domain.SeatType
import woowacourse.movie.domain.system.Seat
import woowacourse.movie.view.model.SeatUiModel

fun Seat.toUiModel(): SeatUiModel = SeatUiModel(
('A' + row - 1).toString() + "$column",
when (this.type) {
SeatType.BType -> R.color.purple_700
SeatType.SType -> R.color.green
SeatType.AType -> R.color.blue
}
)
fun Seat.toUiModel(): SeatUiModel = SeatUiModel(row, col)
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import java.time.LocalDateTime
data class ReservationUiModel(
val title: String,
val screeningDateTime: LocalDateTime,
val peopleCount: Int,
val count: Int,
val seats: List<String>,
val finalReservationFee: Int
val price: Int
) : Parcelable
7 changes: 3 additions & 4 deletions app/src/main/java/woowacourse/movie/view/model/SeatUiModel.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package woowacourse.movie.view.model

class SeatUiModel(
val name: String,
val color: Int
)
class SeatUiModel(row: Int, col: Int) : java.io.Serializable {
val seatId: String = ('A'.code + row).toChar() + (col + 1).toString()
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package woowacourse.movie.view.moviemain.movielist

import woowacourse.movie.R
import woowacourse.movie.data.MovieMockRepository
import woowacourse.movie.domain.Movie
import woowacourse.movie.domain.movie.Movie
import woowacourse.movie.domain.repository.MovieRepository
import woowacourse.movie.view.mapper.toUiModel
import woowacourse.movie.view.model.MovieListModel
Expand Down
Original file line number Diff line number Diff line change
@@ -1,22 +1,21 @@
package woowacourse.movie.view.reservation

import woowacourse.movie.domain.Reservation
import woowacourse.movie.domain.ScreeningTime
import woowacourse.movie.domain.movie.ScreeningTime
import java.time.LocalDate

class ReservationPresenter(private val view: ReservationContract.View) :
ReservationContract.Presenter {
private var peopleCountSaved = 0

override fun onMinusClick() {
if (peopleCountSaved > Reservation.MIN_PEOPLE_COUNT) {
if (peopleCountSaved > 0) {
peopleCountSaved--
view.setCount(peopleCountSaved)
}
}

override fun onPlusClick() {
if (peopleCountSaved < Reservation.MAX_PEOPLE_COUNT) {
if (peopleCountSaved < 20) {
peopleCountSaved++
view.setCount(peopleCountSaved)
}
Expand Down
Loading