-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[둘리] 2, 3단계 자동 DI 미션 제출합니다 #28
Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
168589f
docs: 요구사항 업데이트
hyemdooly 87d3c2a
docs: 요구사항 업데이트
hyemdooly 657518e
feat: 요구사항에 맞게 CartRepository 변경
hyemdooly 1bdceaf
feat: CartProduct 생성
hyemdooly 5e94a5e
rename: Repository 네이밍 변경
hyemdooly 7ab7e4e
feat: Room 사용 구현
hyemdooly 04ac319
refactor: Inject 로직 분리
hyemdooly c75db5c
refactor: Inject 로직 분리
hyemdooly f483bbb
refactor: viewModelFactory 수정
hyemdooly d2744a7
feat: Field 주입에 사용할 Annotation 추가
hyemdooly c6393e6
refactor: getInstance Nullable 허용
hyemdooly 8b64b40
refactor: Field 주입으로 변경
hyemdooly ffa5c7b
feat: Recursive DI 구현
hyemdooly 2254b53
feat: Recursive DI, Field Injection 적용
hyemdooly 8d57300
docs: 요구사항 적용 여부 업데이트
hyemdooly e2b9366
test: Injector Test 작성
hyemdooly 62465b1
feat: 상품의 position과 CartRepository::deleteCartProduct의 id가 동일한 값임을 보장…
hyemdooly 559b93f
feat: 구분을 위한 추가 Annotation 생성
hyemdooly f6c41a8
feat: ViewModel 프로퍼티에 annotations 지정
hyemdooly c0ee682
refactor: 필요없는 괄호 삭제
hyemdooly 38725ee
feat: injector annotation 고려
hyemdooly 55308d0
feat: InMemory, Database 레포지토리 구현
hyemdooly a80f744
feat: 바뀐 요구사항에 맞게 주입 수정
hyemdooly 15b4fe6
feat: annotation 고려를 위한 instances 수정
hyemdooly 37d31ed
test: 바뀐 코드에 맞게 test 수정
hyemdooly 7f5c22d
docs: 요구사항 충족 여부 수정
hyemdooly 368e9c9
rename: DI 모듈화
hyemdooly 83f960e
docs: 모듈화 충족 여부 수정
hyemdooly 6f0dcf2
test: ViewModel 주입 테스트 수정
hyemdooly d66108d
test: di module에 InjectorTest 구현
hyemdooly 5abddb2
test: 액티비티 뷰모델 주입 테스트 보완
hyemdooly b9ebfdf
feat: DI 배포
hyemdooly 0b4f3a1
feat: DI 배포
hyemdooly 2498638
refactor: constructor 제거
hyemdooly 9eecad2
deploy: DI 배포 수정
hyemdooly 8a46ecd
deploy: DI 배포 수정
hyemdooly 8fca93c
refactor: di 버전 수정
hyemdooly a636e8c
refactor: Qualifier 수정, DI 수정
hyemdooly 7184501
refactor: println() 삭제
hyemdooly 7443924
deploy: publishing 옵션 변경
hyemdooly 353d48b
refactor: implementation 추가
hyemdooly bbb76a5
deploy: di release
hyemdooly a89cc44
deploy: di release
hyemdooly acaa5ef
test: 바뀐 di에 따른 테스트 변경
hyemdooly e6ee91f
refactor: 배포된 di 적용
hyemdooly 1f27660
refactor: 전단계의 잔해 삭제
hyemdooly d53b175
refactor: instance return 수정
hyemdooly 885ab4d
refactor: 파라미터명 명시
hyemdooly fa81116
refactor: 변수명 변경
hyemdooly 77bc755
refactor: 파라미터명 변경
hyemdooly ad360bb
refactor: 중복 코드 제거
hyemdooly 55bc13c
refactor: T 타입 non null로 변경
hyemdooly cc6cc2e
refactor: scope function 적용
hyemdooly 6c59beb
refactor: id 계산법 수정
hyemdooly a7baa40
refactor: assertAll 적용
hyemdooly 47600c6
refactor: kotlin class type 고려 제외
hyemdooly a91d38b
refactor: Module 개념 추가
hyemdooly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: kotlin class type 고려 제외
- Loading branch information
commit 47600c6fe3967ca8c32b4f5e252f31076071faed
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object 주입이나 인자가 여러개인 경우 등 다른 경우의 수를 추가해서 테스트 해봤는데 잘 작동하는 것 확인했습니다!