[Internal] Refactoring Animated Builders used in pagination animation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
approved these changes
Oct 3, 2023
lib/src/content/components/paginating_group/main_content_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/main_content_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/main_content_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/navigation_toolbar_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/paginating_widgets_group.dart
Show resolved
Hide resolved
lib/src/content/components/paginating_group/sab_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/sab_animated_builder.dart
Outdated
Show resolved
Hide resolved
lib/src/content/components/paginating_group/navigation_toolbar_animated_builder.dart
Show resolved
Hide resolved
lib/src/content/components/paginating_group/top_bar_animated_builder.dart
Outdated
Show resolved
Hide resolved
…uilder.dart Co-authored-by: Taha Tesser <[email protected]>
…er.dart Co-authored-by: Taha Tesser <[email protected]>
…er.dart Co-authored-by: Taha Tesser <[email protected]>
…_animated_builder.dart Co-authored-by: Taha Tesser <[email protected]>
…ted_builder.dart Co-authored-by: Taha Tesser <[email protected]>
…ted_builder.dart Co-authored-by: Taha Tesser <[email protected]>
…ted_builder.dart Co-authored-by: Taha Tesser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request addresses the current complexities and code duplication arising due to separate implementations for current and outgoing versions of animated builders.
The modifications should not introduce breaking changes to existing functionalities but improve the maintainability and clarity of the codebase. Hence, when testing make sure that nothing has changed visually.
Changes Introduced:
Unified Animated Builder Widgets:
The animated builder widgets for current and outgoing widgets have been unified to avoid redundancy, duplication and enhance code readability.
Renaming Widget Groups:
The current widget group has been renamed as the incoming widget group to reflect the changes more clearly and improve clarity in terminology.
Externalization of Animation Details:
The details to animation have been moved outside of the animated builders, making the internal structure of the animated builders more readible.
Introduction of Enum:
A new Enum,
WoltModalSheetPageTransitionState, has been introduced, which is passed to the unified animated builder to differentiate between incoming and outgoing states efficiently.