Add theme extensions for wolt modal sheet #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3254303
to
3427ac8
Compare
d29ee26
to
f5c2d72
Compare
f5c2d72
to
d85d6f4
Compare
TahaTesser
reviewed
Aug 21, 2023
Comment on lines
+136
to
+143
| extensions: const <ThemeExtension>[ | ||
| WoltModalSheetThemeData( | ||
| heroImageHeight: _heroImageHeight, | ||
| topBarShadowColor: _lightThemeShadowColor, | ||
| modalBarrierColor: Colors.black54, | ||
| ), | ||
| ], | ||
| ), |
TahaTesser
reviewed
Aug 21, 2023
| @@ -93,7 +93,7 @@ class WoltModalSheetPage { | |||
| /// widget often serves as the close button, utilized to close the modal sheet. Together, these | |||
| /// widgets provide clear and intuitive navigational control, differentiating themselves from | |||
| /// the top bar by focusing specifically on directional navigation within the interface. | |||
| final double navigationBarHeight; | |||
| final double? navBarHeight; | |||
There was a problem hiding this comment.
+1 for shorter yet clear name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds theme extensions and fixes #9
theme_extensions.mov
playground.app.mov