Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose value notifier in WoltModalSheet #227

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

ulusoyca
Copy link
Collaborator

@ulusoyca ulusoyca commented Jun 5, 2024

Description

The pageListBuilderNotifier listener should have been disposed properly when the widget is demounted. This causes issues when you launch the modal sheet in the second time. This error is easily reproducible thanks to the well documented issue #226

Before After
before_dispose_Well.mov
after_dispose_Well.mov

Related Issues

#226

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

github-actions bot commented Jun 5, 2024

reverse unnecessary parts from the previous commit
Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ulusoyca ulusoyca merged commit 6c16db9 into main Jun 5, 2024
5 checks passed
@ulusoyca ulusoyca deleted the dispose-value-notifier-listener branch June 5, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants