Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce updateCurrentPage method to update the currently visible page without pagination animation #207

Merged
merged 1 commit into from
May 20, 2024

Conversation

ulusoyca
Copy link
Collaborator

@ulusoyca ulusoyca commented May 20, 2024

Description

This PR introduces the updateCurrentPage method to the WoltModalSheet widget, offering a way to update the currently visible modal sheet page without triggering pagination animations. Currently, the WoltModalSheetPage class is not widget, and this makes it difficult to update the non-widget configuration of the currently visible page. This method enables replacing the page completely with a new configuration.

Related Issues

enable_drag_update_example.mov

Copy link

github-actions bot commented May 20, 2024

Visit the preview URL for this PR (updated for commit bd697c8):

(expires Mon, 27 May 2024 20:34:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

@ulusoyca ulusoyca force-pushed the add-update-method-for-current-page branch from b999e05 to 98ae539 Compare May 20, 2024 20:20
@ulusoyca ulusoyca force-pushed the add-update-method-for-current-page branch from 98ae539 to bd697c8 Compare May 20, 2024 20:31
@ulusoyca ulusoyca enabled auto-merge May 20, 2024 20:33
@ulusoyca ulusoyca requested a review from AcarFurkan May 20, 2024 20:34
@ulusoyca ulusoyca merged commit 8c340fc into main May 20, 2024
4 of 5 checks passed
@ulusoyca ulusoyca deleted the add-update-method-for-current-page branch May 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Page Properties don't work
2 participants