Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR checks #192

Merged
merged 1 commit into from
May 3, 2024
Merged

Update PR checks #192

merged 1 commit into from
May 3, 2024

Conversation

TahaTesser
Copy link
Collaborator

@TahaTesser TahaTesser commented May 2, 2024

fixes Add PR check for tests (Second attempt)

  1. Fix stuck checks.
  2. Update checks to use flutter-action to use Flutter version from pubpec.yaml
  3. Fix typos

Used https://marketplace.visualstudio.com/items?itemName=me-dutour-mathieu.vscode-github-actions to catch issues @ulusoyca

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

github-actions bot commented May 2, 2024

Visit the preview URL for this PR (updated for commit 925294f):

(expires Thu, 09 May 2024 21:28:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

@TahaTesser TahaTesser requested a review from ulusoyca May 2, 2024 21:28
@TahaTesser TahaTesser changed the title Update checks Update PR checks May 2, 2024
@TahaTesser TahaTesser marked this pull request as ready for review May 2, 2024 21:29
@ulusoyca
Copy link
Collaborator

ulusoyca commented May 3, 2024

Update checks to use flutter-action to use Flutter version from pubpec.yaml

@TahaTesser you are simply amazing!

@ulusoyca ulusoyca merged commit c1ba808 into woltapp:main May 3, 2024
5 checks passed
@TahaTesser TahaTesser deleted the fix_gh_actions branch May 3, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR check for tests
2 participants