Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Semantics Feature for Improved Accessibility #150

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

AcarFurkan
Copy link
Collaborator

@AcarFurkan AcarFurkan commented Feb 20, 2024

Description

This update focuses on improving accessibility and semantics within the Wolt Modal Sheet library. By adding semantic labels to buttons, refining modal type logic, and cleaning up the code for better readability, we aim to make applications more inclusive and accessible. These changes are crucial steps towards enhancing user experience and reaching a broader audience.

WhatsApp.Video.2024-02-21.at.23.31.16.mp4

Related Issues

fixes #148

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@AcarFurkan AcarFurkan changed the title Draft: add semantics add semantics Feb 21, 2024
@ulusoyca ulusoyca mentioned this pull request Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Visit the preview URL for this PR (updated for commit 6b988d7):

(expires Tue, 12 Mar 2024 11:18:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

@AcarFurkan AcarFurkan changed the title add semantics Adding Semantics Feature for Improved Accessibility Mar 5, 2024
@ulusoyca ulusoyca merged commit b5c5f24 into woltapp:main Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Semantic Label
2 participants