Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'No MaterialLocalizations found' exception for Cupertino apps #116

Merged

Conversation

yunusemrebakir
Copy link
Collaborator

Description

We are trying to read MaterialLocalizations.of(context).modalBarrierDismissLabel which is not there for Cupertino apps. In this fix;

  • We first try to read it from MaterialLocalizations,
  • If not available, try to read it from CupertinoLocalizations,
  • If that is also not available, return the default label from DefaultMaterialLocalizations.

Note: Test cases will be added after we decide which mocking package to use.

Related Issues

#61

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ulusoyca ulusoyca merged commit b1e0926 into woltapp:main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants