Skip to content

Commit

Permalink
is_close, false positive, adding link to the PR
Browse files Browse the repository at this point in the history
  • Loading branch information
jb-leger authored and wolph committed Nov 8, 2023
1 parent 7483852 commit 7d607c6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion stl/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,9 @@ def is_closed(self, exact=False): # pragma: no cover
"""
Use of not exact is_closed check. This check can lead to misleading
results. You could try to use `exact=True`.
See: https://github.com/wolph/numpy-stl/issues/198
See:
- false positive: https://github.com/wolph/numpy-stl/issues/198
- false negative: https://github.com/wolph/numpy-stl/pull/213
""".strip()
)
normals = numpy.asarray(self.normals, dtype=numpy.float64)
Expand Down

0 comments on commit 7d607c6

Please sign in to comment.