Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a ESP32 based board called JRC board #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JRCBoard
Copy link

For details about technical aspects of JRC Board, the Github link is: github.com/jrcboard
And for board update and description: www.jrcboard.com

For details about technical aspects of JRC Board, the Github link is: github.com/jrcboard
And for board update and description: www.jrcboard.com
In this file, the link of sample video of JRC Board example in Wokwi platform can be found.
@urish urish self-assigned this Apr 30, 2024
@urish
Copy link
Contributor

urish commented May 2, 2024

Thanks for the pull request, I reviewed it.

Unfortunately - the SVG file is not a true vector file, rather a PNG image embedded within an SVG. We need it to be a vector file. I also updated the guidelines to clarify that the graphics needs to be vector.

Also, please remove JRCBoard_example_wokwi.md from the root directory (or move it to live under the same directory of the board.svg/board.json files and rename to README.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants