Switch to input type="text" and @wojtekmaj/predict-input-value package to prevent invalid inputs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laricheva
approved these changes
Jun 17, 2020
|
any update? |
wojtekmaj
force-pushed
the
text-inputs
branch
3 times, most recently
from
6015506
to
91b9c74
Compare
2 tasks
wojtekmaj
force-pushed
the
text-inputs
branch
2 times, most recently
from
af1f56c
to
31060a4
Compare
wojtekmaj
force-pushed
the
text-inputs
branch
from
d8fb4d0
to
31060a4
Compare
As3toJs
approved these changes
Feb 1, 2021
|
Hi, @wojtekmaj could you please merge these to the master. This branch has a fix what we needed. Thanks |
|
It's not done, it's missing min/max validation. It can't be merged like that. |
…e to prevent invalid inputs
…tside of min/max range
|
Thanks to recent improvements to Firefox, an alternative approach will be taken. |
|
@wojtekmaj max for minute input type is not working if maxDetail="minute" but when maxDetail="second" max validation working , what the workaround for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Fixes #87
See also wojtekmaj/react-date-picker#272
TODO: