Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #126

Merged
merged 4 commits into from
Jul 20, 2021
Merged

PHP 8 support #126

merged 4 commits into from
Jul 20, 2021

Conversation

makstech
Copy link

@makstech makstech commented Jul 19, 2021

In this pull request:

  • PHP_CodeSniffer was updated to latest v3.6.0 version, it supports PHP 8.
  • Also, PHP_CodeSniffer has a couple of new rules regarding naming conventions. Excluded these rules, since they require some changes in all files.
  • Fixed a bug that happens on PHP 8

@JeroenDeDauw
Copy link
Collaborator

Added composer.lock to Git, because that's what official docs suggest doing.

That makes sense for applications but not for libraries. The main users of the library will not be affected by the lock file in this repo, so it ends up doing more harm than good.

@makstech
Copy link
Author

Added composer.lock to Git, because that's what official docs suggest doing.

That makes sense for applications but not for libraries. The main users of the library will not be affected by the lock file in this repo, so it ends up doing more harm than good.

Wondering, what harm would it be? :)
A quick run through all questions on StackOverflow, the usual answer is "it does not really matter".
But no problemo, can easily remove it

@makstech
Copy link
Author

  • Reverted most changes
  • Excluded new naming conventions
  • Returned PHP 7.2

@mariushoch mariushoch merged commit 16db1b4 into wmde:master Jul 20, 2021
@mariushoch
Copy link
Member

Thank you for tackling this!

@makstech
Copy link
Author

No problem :)
I want to update the package in the project, how soon can I expect a new version release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants