Sliding overlay #651
Merged
Sliding overlay #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyca
reviewed
Jan 8, 2017
| @@ -81,7 +79,7 @@ private void addScreenStacks() { | |||
|
|
|||
| private void createAndAddScreens(int position) { | |||
| ScreenParams screenParams = params.tabParams.get(position); | |||
| ScreenStack newStack = new ScreenStack(activity, getScreenStackParent(), screenParams.getNavigatorId(), this); | |||
| ScreenStack newStack = new ScreenStack(getActivity(), getScreenStackParent(), screenParams.getNavigatorId(), this); | |||
guyca
reviewed
Jan 8, 2017
| @@ -277,7 +275,7 @@ public void newStack(ScreenParams params) { | |||
| removeView(currentScreenStack.peek()); | |||
| currentScreenStack.destroy(); | |||
|
|
|||
| ScreenStack newStack = new ScreenStack(activity, getScreenStackParent(), params.getNavigatorId(), this); | |||
| ScreenStack newStack = new ScreenStack(getActivity(), getScreenStackParent(), params.getNavigatorId(), this); | |||
guyca
reviewed
Jan 8, 2017
|
|
||
| import android.animation.Animator; | ||
|
|
||
| public class StubAnimatorListener implements Animator.AnimatorListener { |
There was a problem hiding this comment.
This class is redundant, we can use AnimatorListenerAdapter
guyca
reviewed
Jan 8, 2017
| } | ||
|
|
||
| protected ContentView createSlidingOverlayView(SlidingOverlayParams params) { | ||
| final float heightPixels = ViewUtils.convertDpToPixel(100); |
There was a problem hiding this comment.
I prefer we let Js dictate the notification height by using WRAP_CONTENT and setting a specific height in Jsx. wdyt?
DanielZlotin
reviewed
Jan 8, 2017
| ObjectAnimator slideIn = ObjectAnimator.ofFloat(view, TRANSLATION_Y, 0); | ||
| slideIn.setDuration(600); | ||
| slideIn.setInterpolator(new OvershootInterpolator(0.2f)); | ||
|
|
There was a problem hiding this comment.
this screams for slideIn() method
|
|
||
| ObjectAnimator slideOut = ObjectAnimator.ofFloat(view, TRANSLATION_Y, -heightPixels); | ||
| slideIn.setDuration(300); | ||
|
|
| import com.reactnativenavigation.views.slidingOverlay.SlidingOverlay; | ||
| import com.reactnativenavigation.views.slidingOverlay.SlidingOverlaysQueue; | ||
|
|
||
| public abstract class BaseLayout extends RelativeLayout implements Layout { |
There was a problem hiding this comment.
we should prefer encapsulation over inheritance. If anything, this should be called SlidingOverlayLayout but this is yucky :)
| @@ -33,9 +33,8 @@ | |||
| import static android.view.ViewGroup.LayoutParams.MATCH_PARENT; | |||
| import static android.view.ViewGroup.LayoutParams.WRAP_CONTENT; | |||
|
|
|||
| public class BottomTabsLayout extends RelativeLayout implements Layout, AHBottomNavigation.OnTabSelectedListener { | |||
| public class BottomTabsLayout extends BaseLayout implements AHBottomNavigation.OnTabSelectedListener { | |||
There was a problem hiding this comment.
this means this layout can hold a slidingOverlayQueue or something
d4vidi
force-pushed
the
slidingOverlay
branch
from
f6b464d
to
db042ab
Compare
DanielZlotin
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.