Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADB Daemon: Add preliminary server-start in Genycloud #4527

Merged
merged 9 commits into from
Jul 15, 2024
Merged

ADB Daemon: Add preliminary server-start in Genycloud #4527

merged 9 commits into from
Jul 15, 2024

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jul 14, 2024 •
edited
Loading

Description

  • This pull request addresses the issue described here: N/A

In this pull request, I have introduced a preliminary adb start-server command to the Genymotion-cloud case.

This comes as a potential workaround for some instabilities that we've seen which seem to stem from the daemon being down during initial gmsaas adbconnect command.

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi requested a review from noomorph as a code owner July 14, 2024 12:10
@d4vidi
Copy link
Collaborator Author

d4vidi commented Jul 14, 2024

cc @lilinor

@d4vidi d4vidi assigned gosha212 and noomorph and unassigned gosha212 Jul 15, 2024
gosha212
gosha212 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@gosha212 gosha212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

noomorph
noomorph approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@noomorph noomorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM x2

@d4vidi d4vidi merged commit 55915b1 into master Jul 15, 2024
3 checks passed
@d4vidi d4vidi deleted the adb-serverstart branch July 15, 2024 20:19
@d4vidi d4vidi changed the title Daemon: Add preliminary ADB server-start in Genycloud ADB Daemon: Add preliminary ADB server-start in Genycloud Jul 15, 2024
@d4vidi d4vidi changed the title ADB Daemon: Add preliminary ADB server-start in Genycloud ADB Daemon: Add preliminary server-start in Genycloud Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noomorph noomorph noomorph approved these changes

@gosha212 gosha212 gosha212 approved these changes

Assignees

@noomorph noomorph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d4vidi @noomorph @gosha212