Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have bunch of warnings in our code that looks like this:
It looks like those warnings are coming from
mjml-react
becausechildren
are passed as third argument toReact.createElement
. This is most probably wrong. E.g.:JSX is transformed differently for these two cases:
It seems, if
children
is passed as third argument when it is Array, then it is treated as result ofArray.map
and React issues warning about missing key.This fix checks if
children
is Array and in case it is spreads is as arguments toReact.createElement
.