chore: validate passed color #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerdasi
requested review from
daliusd,
MSiliunas,
mastertheblaster and
ArturasCH
daliusd
approved these changes
Dec 11, 2020
src/utils.js
Outdated
| @@ -50,3 +57,16 @@ function numberToPx(name, value) { | |||
| } | |||
| return value; | |||
| } | |||
|
|
|||
| export function colorToHex(name, value) { | |||
| if (!value) { | |||
There was a problem hiding this comment.
What about transparent values ? How they will be represented as hex ?
| return ''; | ||
| } | ||
| let c; | ||
| try { |
There was a problem hiding this comment.
Maybe it's better to validate only the color, not convert to hex ?
return isValid(color) ? color : '';
test/utils.spec.js
Outdated
| @@ -108,4 +110,22 @@ describe('utils', () => { | |||
| expect(addQueryParams('url', { one: '?two' })).to.equal('url?one=%3Ftwo'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('colorToHex', () => { | |||
There was a problem hiding this comment.
Please check also rgb and rgba syntax.
mastertheblaster
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.