Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MjmlSection children optional #21

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Make MjmlSection children optional #21

merged 1 commit into from
Feb 20, 2019

Conversation

chriskalmar
Copy link
Contributor

For MjmlSection I believe the children prop should be optional as well, as one could use MjmlSection purely for decorational purposes.

e.g. using it to display a border

<MjmlSection
  background-color="lightcoral"
  padding="3px 0 0 0"
  border-radius="2px 2px 0px 0px"
/>

@mastertheblaster
Copy link
Collaborator

Thanks for PR, and i think it makes sense

@mastertheblaster mastertheblaster merged commit 7892952 into wix-incubator:master Feb 20, 2019
@chriskalmar chriskalmar deleted the section-proptypes branch February 20, 2019 22:31
@chriskalmar
Copy link
Contributor Author

thanks so much for the fast review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chriskalmar @mastertheblaster