fix(mjml-react): don't trim children, only the final content

wix-incubator · Feb 3, 2021 · 03e853c · 03e853c
1 parent 27fe167
commit 03e853c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/utils/render-to-json.js b/src/utils/render-to-json.js
@@ -43,6 +43,7 @@ const reconciler = ReactReconciler({
  return res;
  },
  appendChildToContainer(container, child) {
+ trimContent(child);
  container.resultObj = child;
  },
  appendInitialChild(parent, child) {
@@ -152,7 +153,15 @@ function escapeTextForBrowser(text) {
  if (typeof text === 'boolean' || typeof text === 'number') {
  return '' + text;
  }
- return escapeHtml(text.trim());
+ return escapeHtml(text);
 }
 
 function noop() {}
+
+function trimContent(child) {
+ if (child.content) {
+ child.content = child.content.trim();
+ } else if (child.children) {
+ child.children.forEach(trimContent);
+ }
+}
diff --git a/test/render-to-json.spec.js b/test/render-to-json.spec.js
@@ -98,6 +98,15 @@ const useCases = [
  <MjmlComment>{'<b /> & $ " '}</MjmlComment>,
 
  <MjmlText>10$ & Free Delivery</MjmlText>,
+
+ <MjmlButton
+ spacesFromBothEnds=" both "
+ spaceFromLeft=" left"
+ spaceFromRight="right "
+ spaceInBetween=" in between "
+ >
+ {' '}Hello World ! <span> Hello World ! </span>{' '}
+ </MjmlButton>,
 ];
 
 useCases.forEach((tree, i) => {