Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add atlantic-night theme #14

Merged
merged 3 commits into from
Mar 31, 2022
Merged

feat: add atlantic-night theme #14

merged 3 commits into from
Mar 31, 2022

Conversation

mrpbennett
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This includes the Atlantic Night theme into the theme directory for fig

@mrpbennett mrpbennett changed the title adding atlantic night theme feat: adding atlantic night theme Mar 11, 2022
fedeci
fedeci suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the .DS_Store file that got committed please?

@mrpbennett
Copy link
Contributor Author

How can I remove this without adding a .gitignore into my commit?

@fedeci
Copy link
Contributor

fedeci commented Mar 31, 2022 •
edited
Loading

For sure you can add a .gitignore and it would be really welcomed!
However you will still need to run git rm .DS_Store.

@mrpbennett
Copy link
Contributor Author

Finally manage to remove it :D

fedeci
fedeci approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedeci fedeci changed the title feat: adding atlantic night theme feat: add atlantic-night theme Mar 31, 2022
@fedeci fedeci merged commit ff168ea into withfig:main Mar 31, 2022
@mrpbennett mrpbennett deleted the atlantic-night branch April 1, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrpbennett @fedeci