Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for unsupported browser APIs #557

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

mschrage
Copy link
Member

@mschrage mschrage commented Sep 3, 2021

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Completion specs can use Browser APIs that are supported in newer versions of WebKit, but break when run on older machines.
What is the new behavior (if this is a feature change)?
Add eslint-compat-plugin to check for the use browser APIs that are not supported across all necessary versions of Safari (WKWebview).

@withfig-bot
Copy link
Collaborator

No files changed ☑️

@withfig-bot
Copy link
Collaborator

Hello @mschrage,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments have the arg property (arg: {})?
  • Are all options modular? E.g. a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll consider adding usage based polyfills too.

Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuiiBz QuiiBz merged commit 7aeee1f into master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants