-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws] sso login #543
[aws] sso login #543
Conversation
Overviewdev/aws/sso.ts:Info:dev/aws/configure.ts:Info:URLs:
|
Hello @danilofuchs,
Please add a 👍 as a reaction to this comment to show that you read this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution!
We only have two comments to resolve before getting this PR merged in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this PR!
Implements the only missing suggestion for AWS SSO
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/sso/index.html#cli-aws-sso