Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] sso login #543

Merged
merged 2 commits into from
Sep 3, 2021
Merged

[aws] sso login #543

merged 2 commits into from
Sep 3, 2021

Conversation

danilofuchs
Copy link
Contributor

@withfig-bot
Copy link
Collaborator

withfig-bot commented Aug 31, 2021

Overview

dev/aws/sso.ts:

Info:

dev/aws/configure.ts:

Info:

URLs:

  • https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html

@withfig-bot
Copy link
Collaborator

Hello @danilofuchs,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments have the arg property (arg: {})?
  • Are all options modular? E.g. a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

dev/aws/sso.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution!

We only have two comments to resolve before getting this PR merged in.

dev/aws/sso.ts Outdated Show resolved Hide resolved
dev/aws/sso.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this PR!

@QuiiBz QuiiBz merged commit e57316c into withfig:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants