fix: Better alignment of selected option within select box.

[rgilsimoes]

Description

• Closes Select options are not centrally aligned #1552
• Improves selected option alignment on select component.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e4c1c3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
starlight	✅ Ready (Inspect)	Visit Preview	Jun 6, 2024 5:46pm

[at-the-vr]

I think its the position (left/right) of Icons that needs to be fixed wrt the Issue linked that is to centrally align items inside the label

[rgilsimoes]

That was the issue request but my suggestion was just to adjust the icon placement. @delucis was ok with this approach as well.

[delucis]

Thanks for tackling this @rgilsimoes! And for your patience waiting on a review.

I noticed this changes the overall spacing of the components, not only the outline positioning:

Before

After

Basically now there is more spacing to the left of the menus, causing unbalanced spacing around the vertical line for example.

I think we should aim to match the current layout and only move the outline. Do you think you could tackle that?

[rgilsimoes]

I think we should aim to match the current layout and only move the outline. Do you think you could tackle that?

That will cause the outline of the ThemeSelector to be very close to the vertical line. Is that intended?

I think the outline is the point of reference to space the elements evenly:

[delucis]

I think the outline is the point of reference to space the elements evenly:

Yes, I think that’s fine! I think the outline is understood as an overlay on the layout, and is not visible most of the time, so we should optimize the layout for the most common display style (i.e. when the outline is not visible).

[evadecker]

@rgilsimoes Are you planning to continue this PR? This alignment has been bugging me too 😅

Happy to contribute to this PR or create a new branch if you’d like assistance!

[delucis]

@evadecker Would love the contribution! Feel free to make suggestions on this PR if that’s enough to fix it, or open a new one. Thank you 💖

[evadecker]

@evadecker Would love the contribution! Feel free to make suggestions on this PR if that’s enough to fix it, or open a new one. Thank you 💖

PR up: #2062

[rgilsimoes]

Sorry for the late reply! Schedule has been tight! Thank's for continuing @evadecker !