Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the code example of <Code /> with transformers inapi-reference.mdx #8618

Closed
wants to merge 1 commit into from

Conversation

liruifengv
Copy link
Sponsor Member

@liruifengv liruifengv commented Jun 21, 2024

Description (required)

  • Update the code example of <Code /> with transformers

  • <Code /> alone in the .astro file does not render correctly.

  • I don't know if this is a bug, only update the docs to make sense for people that want quickrun.

    Before After
    Steps list numbered 1, 4, 5 Steps list numbered 1, 2, 3

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 21, 2024 3:11am

@liruifengv liruifengv changed the title i18n(zh-cn): update api-reference.mdx Update api-reference.mdx Jun 21, 2024
@liruifengv liruifengv changed the title Update api-reference.mdx Update <Code /> with transformers code example inapi-reference.mdx Jun 21, 2024
@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv liruifengv changed the title Update <Code /> with transformers code example inapi-reference.mdx Update the code example of <Code /> with transformers inapi-reference.mdx Jun 21, 2024
@sarah11918
Copy link
Member

I'm not sure it's expected that the <Code /> component should need a wrapping <div> to style it!

Maybe we should first check to see whether this is a bug, or something about the implementation in withastro/astro#11197

Can @ematipico @bluwy or @braebo help us out here with the code sample we should document, and whether this behavior is expected?

@braebo
Copy link

braebo commented Jun 21, 2024

That particular div in the example is indeed extraneous and unrelated to styling.

@sarah11918
Copy link
Member

@liruifengv - You might have found a bug then! If you can reproduce for the team, can you please file an Astro issue?

I'll close this as a Docs PR since the intended behaviour is already documented.

@sarah11918 sarah11918 closed this Jun 21, 2024
@liruifengv
Copy link
Sponsor Member Author

@liruifengv - You might have found a bug then! If you can reproduce for the team, can you please file an Astro issue?

I'll close this as a Docs PR since the intended behaviour is already documented.

Ok. I will open a issue for core repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants