-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional explanation about define:vars directive #8585
Add additional explanation about define:vars directive #8585
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @ArmandPhilippot and I really appreciate you taking the time both to point out the issues and suggested fixes and to come and make a PR to improve the documentation. Welcome to Team Docs! 🥳
* translate the two pages updated in withastro#8585 * fix two typo (plural and verb agreement)
* translate the two pages updated in #8585 * fix two typo (plural and verb agreement) ----- Co-authored-by: Thomas Bonnet <[email protected]> Co-authored-by: Yan <[email protected]>
Description (required)
I added additional information about
define:vars
directive on two pages:The
define:vars
directive does not work with dynamic tags and I have seen some issues related to that on the main repository so I think it should be clarified.The statement was not exact since, as stated in #3165: using
define:vars
on<style />
tag does not automatically apply theis:inline
directive.Related issues & labels (optional)
First-time contributor to Astro Docs?
ar_phi
(I'm not often connected... but I should get an email when mentioned if needed.)