Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional explanation about define:vars directive #8585

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

ArmandPhilippot
Copy link
Contributor

Description (required)

I added additional information about define:vars directive on two pages:

The define:vars directive does not work with dynamic tags and I have seen some issues related to that on the main repository so I think it should be clarified.

The statement was not exact since, as stated in #3165: using define:vars on <style /> tag does not automatically apply the is:inline directive.

Related issues & labels (optional)

First-time contributor to Astro Docs?

ar_phi

(I'm not often connected... but I should get an email when mentioned if needed.)

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 19, 2024 9:42pm
docs-i18n 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 9:42pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 19, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-syntax.mdx Source changed, localizations will be marked as outdated.
en reference/directives-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ArmandPhilippot and I really appreciate you taking the time both to point out the issues and suggested fixes and to come and make a PR to improve the documentation. Welcome to Team Docs! 🥳

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 19, 2024
@sarah11918 sarah11918 merged commit a14dce7 into withastro:main Jun 19, 2024
8 checks passed
@ArmandPhilippot ArmandPhilippot deleted the doc/add-define-vars-info branch June 19, 2024 21:58
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jun 21, 2024
* translate the two pages updated in withastro#8585
* fix two typo (plural and verb agreement)
yanthomasdev pushed a commit that referenced this pull request Jun 25, 2024
* translate the two pages updated in #8585
* fix two typo (plural and verb agreement)

-----
Co-authored-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning about dynamic tags and reword another in Template Directives
3 participants