Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[guides/content/] polished and ready for i18n! #8556

Merged
merged 7 commits into from
Jun 17, 2024
Merged

[guides/content/] polished and ready for i18n! #8556

merged 7 commits into from
Jun 17, 2024

Conversation

sarah11918
Copy link
Member

Description (required)

Marks the "Authoring Content" page as i18nReady: true (I see what you did, es, ja and zh-cn!! 😉 )

Also polishes the content before most languages start translating it.

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Jun 17, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 0:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 17, 2024 0:49am

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 17, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/content.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv liruifengv mentioned this pull request Jun 17, 2024
Merged
@yanthomasdev
Copy link
Member

ha, i18nReady is one of our ignoreKeywords, so I'll rename the PR so we don't merge it accidentally with this name

@yanthomasdev yanthomasdev changed the title [guides/content/] polished and i18nReady! [guides/content/] polished and ready for i18n! Jun 17, 2024
yanthomasdev
yanthomasdev reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small link issue Lirui flagged, otherwise LGTM!

@sarah11918 @liruifengv
fix link
d27f2f8 
Co-authored-by: liruifengv <[email protected]>
@sarah11918
Copy link
Member Author

Thank you both! 💜

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 17, 2024
@sarah11918
Copy link
Member Author

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Yan <[email protected]>
Co-authored-by: liruifengv <[email protected]>

@sarah11918 sarah11918 merged commit eead489 into main Jun 17, 2024
8 checks passed
@sarah11918 sarah11918 deleted the authoring-content branch June 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruifengv liruifengv liruifengv left review comments

@yanthomasdev yanthomasdev yanthomasdev left review comments

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sarah11918 @astrobot-houston @yanthomasdev @liruifengv