Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checked indicator for Option component in forced colors #8536

Merged

Conversation

srapilly
Copy link
Contributor

Description (required)

This fix an issue on forced mode, similar to this PR that was already merged #933

Before (No visual checked indicator):
image

After:
image

The starlight and doc website seems to have a great accessibility, great job on this!

Related issues & labels

  • Suggested label: a11y

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 17, 2024 0:42am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@srapilly srapilly marked this pull request as ready for review June 15, 2024 23:23
@sarah11918 sarah11918 added site improvement Some thing that improves the website functionality - ask @delucis for help! a11y Anything to do with improving accessibility labels Jun 17, 2024
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this, amazing work @srapilly. And welcome to Team Docs! 💜

@yanthomasdev yanthomasdev merged commit da6f2f5 into withastro:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Anything to do with improving accessibility site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants